summaryrefslogtreecommitdiffstats
path: root/filter
diff options
context:
space:
mode:
authorTomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>2021-06-06 20:55:28 +0900
committerMichael Stahl <michael.stahl@allotropia.de>2021-06-07 13:03:47 +0200
commitdb6efbaf5f9d6ae818afccec6a9fab219268b621 (patch)
treed52130b64adcfdaef799424f9efa5a65c5b9972b /filter
parentupdate credits (diff)
downloadcore-db6efbaf5f9d6ae818afccec6a9fab219268b621.tar.gz
core-db6efbaf5f9d6ae818afccec6a9fab219268b621.zip
tdf#142478 fix crash when searching and a viewshell change occurs
When searching a impress document for a word, and the word is in notes as welll as in the document, a crash happens (only when searching with "find all"). The regressing commit changed that the search is now bound to a view (and to a viewshell). When searching for words in notes and document, at the transition from "standard" to "notes" page kind mode, the view and viewshells are destroyed and the new one created again. The problem lies here as when we destroy the viewshell, we also destroy the search context and FuSearch objects, but we are still executing the search -> crash. The solution for this is that when we change the page kind, we take the FuSearch object from the old viewshell and put it into the newly created viewshell, so that we keep the FuSearch object alive and don't throw away the search context too. Change-Id: I50931cca2a20c5704f7450e3cc8b3466af4c5a3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116758 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 3b75f9add7ed80e803b0771d86892d6ca0f47e71) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116703 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Diffstat (limited to 'filter')
0 files changed, 0 insertions, 0 deletions