diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2016-05-10 16:42:16 +0200 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2016-05-10 16:42:16 +0200 |
commit | 14cd5182c5f64c43581c82db8c958369152226ac (patch) | |
tree | 57f150ba2707f29214eeb9b1eaad2373780d1b15 /filter/source/graphicfilter/ipbm/ipbm.cxx | |
parent | Note pull request for boost patch (diff) | |
download | core-14cd5182c5f64c43581c82db8c958369152226ac.tar.gz core-14cd5182c5f64c43581c82db8c958369152226ac.zip |
Replace fallthrough comments with new SAL_FALLTHROUGH macro
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in
preparation of enabling -Wimplicit-fallthrough. (This is only relevant for
C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.)
Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but
that would require adding back in dependencies on boost_headers to many
libraries where we carefully removed any remaining Boost dependencies only
recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its
future evolution will not have any impact on the stable URE interface.) C++17
will have a proper [[fallthroug]], eventually removing the need for a macro
altogether.
Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
Diffstat (limited to 'filter/source/graphicfilter/ipbm/ipbm.cxx')
-rw-r--r-- | filter/source/graphicfilter/ipbm/ipbm.cxx | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/filter/source/graphicfilter/ipbm/ipbm.cxx b/filter/source/graphicfilter/ipbm/ipbm.cxx index 58d376ed564e..7cdc3e1cd795 100644 --- a/filter/source/graphicfilter/ipbm/ipbm.cxx +++ b/filter/source/graphicfilter/ipbm/ipbm.cxx @@ -156,7 +156,7 @@ bool PBMReader::ImplReadHeader() { case '1' : mbRaw = false; - //fall-through + SAL_FALLTHROUGH; case '4' : mnMode = 0; nMax = 2; // number of parameters in Header @@ -164,14 +164,14 @@ bool PBMReader::ImplReadHeader() break; case '2' : mbRaw = false; - //fall-through + SAL_FALLTHROUGH; case '5' : mnMode = 1; nMax = 3; break; case '3' : mbRaw = false; - //fall-through + SAL_FALLTHROUGH; case '6' : mnMode = 2; nMax = 3; |