diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-09-28 10:33:09 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-09-29 08:51:48 +0200 |
commit | 1ffba0e356608fb6dbf568248e2a953b4d7fb5d6 (patch) | |
tree | 5da59640441292421f2137bc85ee7291daed137e /embeddedobj | |
parent | Adapt loplugin:reservedid to Windows (diff) | |
download | core-1ffba0e356608fb6dbf568248e2a953b4d7fb5d6.tar.gz core-1ffba0e356608fb6dbf568248e2a953b4d7fb5d6.zip |
loplugin:flatten check for throw in then clause
also make the plugin ignore the case where we have var decl's in the
clause we want to flatten, which could lead to problematic extension of
variable lifetime
Change-Id: I3061f7104e8c6a460bf74f5eac325a516ec50c59
Reviewed-on: https://gerrit.libreoffice.org/42889
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'embeddedobj')
-rw-r--r-- | embeddedobj/source/commonembedding/persistence.cxx | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/embeddedobj/source/commonembedding/persistence.cxx b/embeddedobj/source/commonembedding/persistence.cxx index 2a5d09bfeb94..07bc635a44a4 100644 --- a/embeddedobj/source/commonembedding/persistence.cxx +++ b/embeddedobj/source/commonembedding/persistence.cxx @@ -1770,11 +1770,8 @@ void SAL_CALL OCommonEmbeddedObject::breakLink( const uno::Reference< embed::XSt "The object is not a valid linked object!", static_cast< ::cppu::OWeakObject* >(this) ); } - else - { - // the current implementation of OOo links does not implement this method since it does not implement - // all the set of interfaces required for OOo embedded object ( XEmbedPersist is not supported ). - } + // the current implementation of OOo links does not implement this method since it does not implement + // all the set of interfaces required for OOo embedded object ( XEmbedPersist is not supported ). if ( !xStorage.is() ) throw lang::IllegalArgumentException( "No parent storage is provided!", |