diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-04-30 09:26:47 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-04-30 09:28:40 +0200 |
| commit | e02b9ccf58e9eda01f8588868ec2f367f7075dcf (patch) | |
| tree | b70be51bbafd7adb8515dbd4c89570dd60bbfc46 /dictionaries | |
| parent | PPTX import: store OOXTheme in InteropGrabBag for SmartArt re-generation (diff) | |
| download | core-e02b9ccf58e9eda01f8588868ec2f367f7075dcf.tar.gz core-e02b9ccf58e9eda01f8588868ec2f367f7075dcf.zip | |
revert part of "improve loplugin:stringconstant"
Revert part of
commit dd8d5e5795358d732a9f7a8af7c35f662321e332
Date: Mon Apr 29 11:18:21 2019 +0200
improve loplugin:stringconstant
sberg's original gerrit comment:
but there can also be other problematic overloads for parameters like
`void const *` or `std::string_view`. I'm not sure this change is worth
the potential false positives.
and continuing IRC discussion:
<noelgrandin> I'll revert the compilerplugins/ part
<sberg> noelgrandin, my main concern is that /if/ somebody eventually
runs into such an overload situation, it's really hard to get the
warnings/errors fixed for those people, short of going into the plugin
itself
Change-Id: I4916ce8943c4319d7ef9084e22d6a0eeb430b15c
Diffstat (limited to 'dictionaries')
0 files changed, 0 insertions, 0 deletions