summaryrefslogtreecommitdiffstats
path: root/desktop
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2011-09-28 22:39:16 +0100
committerCaolán McNamara <caolanm@redhat.com>2011-09-29 09:33:45 +0100
commitaf1a8de15e0b8b9a74ff891a8b5e2e6310631358 (patch)
treece012659d42f110d156a631e47950bd6d603e498 /desktop
parentByteString->rtl::OString (diff)
downloadcore-af1a8de15e0b8b9a74ff891a8b5e2e6310631358.tar.gz
core-af1a8de15e0b8b9a74ff891a8b5e2e6310631358.zip
why use a pointer when a reference will do
Diffstat (limited to 'desktop')
-rw-r--r--desktop/source/app/officeipcthread.cxx20
1 files changed, 10 insertions, 10 deletions
diff --git a/desktop/source/app/officeipcthread.cxx b/desktop/source/app/officeipcthread.cxx
index 022ccf1eada2..ef6557ecbf3d 100644
--- a/desktop/source/app/officeipcthread.cxx
+++ b/desktop/source/app/officeipcthread.cxx
@@ -188,32 +188,32 @@ private:
sal_Int32 m_index;
};
-bool addArgument(
- ByteString * arguments, char prefix, rtl::OUString const & argument)
+bool addArgument(ByteString &rArguments, char prefix,
+ const rtl::OUString &rArgument)
{
rtl::OString utf8;
- if (!argument.convertToString(
+ if (!rArgument.convertToString(
&utf8, RTL_TEXTENCODING_UTF8,
(RTL_UNICODETOTEXT_FLAGS_UNDEFINED_ERROR |
RTL_UNICODETOTEXT_FLAGS_INVALID_ERROR)))
{
return false;
}
- *arguments += prefix;
+ rArguments += prefix;
for (sal_Int32 i = 0; i < utf8.getLength(); ++i) {
char c = utf8[i];
switch (c) {
case '\0':
- *arguments += "\\0";
+ rArguments += "\\0";
break;
case ',':
- *arguments += "\\,";
+ rArguments += "\\,";
break;
case '\\':
- *arguments += "\\\\";
+ rArguments += "\\\\";
break;
default:
- *arguments += c;
+ rArguments += c;
break;
}
}
@@ -542,7 +542,7 @@ OfficeIPCThread::Status OfficeIPCThread::EnableOfficeIPCThread()
ByteString aArguments(RTL_CONSTASCII_STRINGPARAM(ARGUMENT_PREFIX));
rtl::OUString cwdUrl;
if (!(tools::getProcessWorkingDir(cwdUrl) &&
- addArgument(&aArguments, '1', cwdUrl)))
+ addArgument(aArguments, '1', cwdUrl)))
{
aArguments += '0';
}
@@ -550,7 +550,7 @@ OfficeIPCThread::Status OfficeIPCThread::EnableOfficeIPCThread()
for( sal_uInt32 i=0; i < nCount; i++ )
{
rtl_getAppCommandArg( i, &aDummy.pData );
- if (!addArgument(&aArguments, ',', aDummy)) {
+ if (!addArgument(aArguments, ',', aDummy)) {
return IPC_STATUS_BOOTSTRAP_ERROR;
}
}