diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2018-10-09 10:28:48 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2018-10-09 14:47:17 +0200 |
| commit | 7ceee0f1ec0e349d0df4980d7fdedbd13c7917c5 (patch) | |
| tree | 616ab419fe0f01e94740de7faacb393775420589 /desktop/unx | |
| parent | loplugin:unusedmethods (diff) | |
| download | core-7ceee0f1ec0e349d0df4980d7fdedbd13c7917c5.tar.gz core-7ceee0f1ec0e349d0df4980d7fdedbd13c7917c5.zip | |
Extend loplugin:redundantinline to catch inline functions w/o external linkage
...where "inline" (in its meaning of "this function can be defined in multiple
translation units") thus doesn't make much sense. (As discussed in
compilerplugins/clang/redundantinline.cxx, exempt such "static inline" functions
in include files for now.)
All the rewriting has been done automatically by the plugin, except for one
instance in sw/source/ui/frmdlg/column.cxx that used to involve an #if), plus
some subsequent solenv/clang-format/reformat-formatted-files.
Change-Id: Ib8b996b651aeafc03bbdc8890faa05ed50517224
Reviewed-on: https://gerrit.libreoffice.org/61573
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'desktop/unx')
| -rw-r--r-- | desktop/unx/source/splashx.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/desktop/unx/source/splashx.c b/desktop/unx/source/splashx.c index 71858367f92f..e03fc094abcb 100644 --- a/desktop/unx/source/splashx.c +++ b/desktop/unx/source/splashx.c @@ -193,7 +193,7 @@ static void splash_setup( struct splash* splash, int const barc[3], int const fr #define SHIFT( x, bits ) ( ( (bits) >= 0 )? ( (x) << (bits) ): ( (x) >> -(bits) ) ) // Position of the highest bit (more or less integer log2) -static inline int HIGHEST_BIT( unsigned long x ) +static int HIGHEST_BIT( unsigned long x ) { int i = 0; for ( ; x; ++i ) @@ -203,7 +203,7 @@ static inline int HIGHEST_BIT( unsigned long x ) } // Number of bits set to 1 -static inline int BITS( unsigned long x ) +static int BITS( unsigned long x ) { int i = 0; for ( ; x; x >>= 1 ) |