summaryrefslogtreecommitdiffstats
path: root/dbaccess
diff options
context:
space:
mode:
authorTor Lillqvist <tml@iki.fi>2012-04-23 21:22:26 +0300
committerTor Lillqvist <tlillqvist@suse.com>2012-04-24 12:22:49 +0300
commit23670b4dc7881d1aea9088c2cd89f2b0a3846dce (patch)
treeb3ac0de585387d17e96eb343815c8d8703e45449 /dbaccess
parentWaE: unused variable (diff)
downloadcore-23670b4dc7881d1aea9088c2cd89f2b0a3846dce.tar.gz
core-23670b4dc7881d1aea9088c2cd89f2b0a3846dce.zip
WaE: use of logical '&&' with constant operand
Diffstat (limited to 'dbaccess')
-rw-r--r--dbaccess/source/ui/browser/unodatbr.cxx7
1 files changed, 7 insertions, 0 deletions
diff --git a/dbaccess/source/ui/browser/unodatbr.cxx b/dbaccess/source/ui/browser/unodatbr.cxx
index 3080e56d3e8c..8ec842068115 100644
--- a/dbaccess/source/ui/browser/unodatbr.cxx
+++ b/dbaccess/source/ui/browser/unodatbr.cxx
@@ -2275,6 +2275,12 @@ IMPL_LINK(SbaTableQueryBrowser, OnExpandEntry, SvLBoxEntry*, _pParent)
if (xWarnings.is())
{
SQLExceptionInfo aWarnings(xWarnings->getWarnings());
+#if 0
+// Obviously this if test is always false. So to avoid a Clang warning
+// "use of logical '&&' with constant operand" I put this in #if
+// 0. Yeah, I know it is fairly likely nobody will ever read this
+// comment and make a decision what to do here, so I could as well
+// have just binned this...
if (aWarnings.isValid() && sal_False)
{
SQLContext aContext;
@@ -2284,6 +2290,7 @@ IMPL_LINK(SbaTableQueryBrowser, OnExpandEntry, SvLBoxEntry*, _pParent)
aWarnings = aContext;
showError(aWarnings);
}
+#endif
// TODO: we need a better concept for these warnings:
// something like "don't show any warnings for this datasource, again" would be nice
// But this requires an extension of the InteractionHandler and an additional property on the data source