diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2012-03-14 13:27:56 +0100 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2012-03-14 13:32:02 +0100 |
commit | 6e67c03dc0225fc66343546b14e902b9d238b1a3 (patch) | |
tree | 6e078783d65e280a721b4e46f0ae0ca6b950f121 /dbaccess | |
parent | fdo#47246: dtrans: fix multiply linked ImplHelper (diff) | |
download | core-6e67c03dc0225fc66343546b14e902b9d238b1a3.tar.gz core-6e67c03dc0225fc66343546b14e902b9d238b1a3.zip |
Enable -Wnon-virtual-dtor for GCC 4.6
...which has the necessary features to support it.
Change a lot of classes to either contain a protected non-virtual dtor
(which is backwards compatible, so even works for cppumaker-generated
UNO headers) or a public virtual one.
cppuhelper/propertysetmixin.hxx still needs to disable the warning, as
the relevant class has a non-virtual dtor but friends, which would still
cause GCC to warn.
Includes a patch for libcmis, intended to be upstreamed.
Diffstat (limited to 'dbaccess')
19 files changed, 69 insertions, 0 deletions
diff --git a/dbaccess/inc/IController.hxx b/dbaccess/inc/IController.hxx index 962782ea5e18..78cce794e77e 100644 --- a/dbaccess/inc/IController.hxx +++ b/dbaccess/inc/IController.hxx @@ -130,6 +130,9 @@ namespace dbaui /** allows interception of user input, aka mouse clicks and key events */ virtual bool interceptUserInput( const NotifyEvent& _rEvent ) = 0; + + protected: + ~IController() {} }; } #endif // DBAUI_ICONTROLLER_HXX diff --git a/dbaccess/inc/IReference.hxx b/dbaccess/inc/IReference.hxx index 01534f6063e0..959a0b199d1f 100644 --- a/dbaccess/inc/IReference.hxx +++ b/dbaccess/inc/IReference.hxx @@ -38,6 +38,9 @@ namespace dbaui public: virtual void SAL_CALL acquire( ) throw () = 0; virtual void SAL_CALL release( ) throw () = 0; + + protected: + ~IReference() {} }; } #endif // DBAUI_IREFERENCE_HXX diff --git a/dbaccess/source/core/inc/RefreshListener.hxx b/dbaccess/source/core/inc/RefreshListener.hxx index 80e490c4a34c..dbd3b8aada5e 100644 --- a/dbaccess/source/core/inc/RefreshListener.hxx +++ b/dbaccess/source/core/inc/RefreshListener.hxx @@ -47,6 +47,9 @@ namespace dbaccess { public: virtual void refresh(const ::com::sun::star::uno::Reference< ::com::sun::star::container::XNameAccess >& _rToBeRefreshed) = 0; + + protected: + ~IRefreshListener() {} }; } // namespace dbaccess diff --git a/dbaccess/source/core/inc/column.hxx b/dbaccess/source/core/inc/column.hxx index b6e533a81a35..93333f87282e 100644 --- a/dbaccess/source/core/inc/column.hxx +++ b/dbaccess/source/core/inc/column.hxx @@ -150,6 +150,9 @@ namespace dbaccess /** notifies that a column with a given name has been dropped */ virtual void columnDropped( const ::rtl::OUString& _sName ) = 0; + + protected: + ~IColumnFactory() {} }; //============================================================ diff --git a/dbaccess/source/core/inc/columnsettings.hxx b/dbaccess/source/core/inc/columnsettings.hxx index c407b60820a8..c976e332b23c 100644 --- a/dbaccess/source/core/inc/columnsettings.hxx +++ b/dbaccess/source/core/inc/columnsettings.hxx @@ -62,6 +62,9 @@ namespace dbaccess const ::com::sun::star::uno::Type& _rType, const void* _pInitialValue ) = 0; + + protected: + ~IPropertyContainer() {} }; //==================================================================== diff --git a/dbaccess/source/core/inc/containerapprove.hxx b/dbaccess/source/core/inc/containerapprove.hxx index abedd666e0f3..b88e945afd6d 100644 --- a/dbaccess/source/core/inc/containerapprove.hxx +++ b/dbaccess/source/core/inc/containerapprove.hxx @@ -52,6 +52,8 @@ namespace dbaccess class SAL_NO_VTABLE IContainerApprove { public: + virtual ~IContainerApprove() {} + /** approves a given element for insertion into the container @param _rName specifies the name under which the element is going to be inserted diff --git a/dbaccess/source/ext/macromigration/migrationprogress.hxx b/dbaccess/source/ext/macromigration/migrationprogress.hxx index 9c1598a43855..a0724c0c42c4 100644 --- a/dbaccess/source/ext/macromigration/migrationprogress.hxx +++ b/dbaccess/source/ext/macromigration/migrationprogress.hxx @@ -50,6 +50,9 @@ namespace dbmm virtual void start( const sal_uInt32 _nOverallRange ) = 0; virtual void setOverallProgressText( const ::rtl::OUString& _rText ) = 0; virtual void setOverallProgressValue( const sal_uInt32 _nValue ) = 0; + + protected: + ~IMigrationProgress() {} }; //........................................................................ diff --git a/dbaccess/source/ext/macromigration/progressmixer.hxx b/dbaccess/source/ext/macromigration/progressmixer.hxx index dd52a72d134d..22c6b44558cf 100644 --- a/dbaccess/source/ext/macromigration/progressmixer.hxx +++ b/dbaccess/source/ext/macromigration/progressmixer.hxx @@ -52,6 +52,9 @@ namespace dbmm virtual void start( sal_uInt32 _nRange ) = 0; virtual void advance( sal_uInt32 _nValue ) = 0; virtual void end() = 0; + + protected: + ~IProgressConsumer() {} }; //==================================================================== diff --git a/dbaccess/source/ui/app/IApplicationController.hxx b/dbaccess/source/ui/app/IApplicationController.hxx index 5e7123e4d3ed..3d28e3f15086 100644 --- a/dbaccess/source/ui/app/IApplicationController.hxx +++ b/dbaccess/source/ui/app/IApplicationController.hxx @@ -92,6 +92,9 @@ namespace dbaui /// called when an object container of any kind was found during enumerating tree view elements virtual void containerFound( const ::com::sun::star::uno::Reference< ::com::sun::star::container::XContainer >& _xContainer) = 0; + + protected: + ~IApplicationController() {} }; //........................................................................ diff --git a/dbaccess/source/ui/inc/IClipBoardTest.hxx b/dbaccess/source/ui/inc/IClipBoardTest.hxx index 2f64d667379d..7daf155de1b0 100644 --- a/dbaccess/source/ui/inc/IClipBoardTest.hxx +++ b/dbaccess/source/ui/inc/IClipBoardTest.hxx @@ -43,6 +43,9 @@ namespace dbaui virtual void copy() = 0; virtual void cut() = 0; virtual void paste() = 0; + + protected: + ~IClipboardTest() {} }; } #endif // DBACCESS_TABLEDESIGN_ICLIPBOARDTEST_HXX diff --git a/dbaccess/source/ui/inc/IItemSetHelper.hxx b/dbaccess/source/ui/inc/IItemSetHelper.hxx index d5bd9058582f..e117850178b2 100644 --- a/dbaccess/source/ui/inc/IItemSetHelper.hxx +++ b/dbaccess/source/ui/inc/IItemSetHelper.hxx @@ -54,6 +54,9 @@ namespace dbaui public: virtual const SfxItemSet* getOutputSet() const = 0; virtual SfxItemSet* getWriteOutputSet() = 0; + + protected: + ~IItemSetHelper() {} }; class SAL_NO_VTABLE IDatabaseSettingsDialog @@ -73,6 +76,9 @@ namespace dbaui In a normal tab dialog, this will usually disable the "OK" button. */ virtual void enableConfirmSettings( bool _bEnable ) = 0; + + protected: + ~IDatabaseSettingsDialog() {} }; } #endif // DBAUI_ITEMSETHELPER_HXX diff --git a/dbaccess/source/ui/inc/IUpdateHelper.hxx b/dbaccess/source/ui/inc/IUpdateHelper.hxx index b9976efe9935..d416b4d7bdc3 100644 --- a/dbaccess/source/ui/inc/IUpdateHelper.hxx +++ b/dbaccess/source/ui/inc/IUpdateHelper.hxx @@ -46,6 +46,9 @@ namespace dbaui virtual void updateTimestamp(sal_Int32 _nPos,const ::com::sun::star::util::DateTime& _nValue) = 0; virtual void moveToInsertRow() = 0; virtual void insertRow() = 0; + + protected: + ~IUpdateHelper() {} }; } diff --git a/dbaccess/source/ui/inc/WCopyTable.hxx b/dbaccess/source/ui/inc/WCopyTable.hxx index ca7f272ff1e0..cc7931b82bf9 100644 --- a/dbaccess/source/ui/inc/WCopyTable.hxx +++ b/dbaccess/source/ui/inc/WCopyTable.hxx @@ -56,6 +56,9 @@ namespace dbaui { public: virtual bool operator()(const ::rtl::OUString& _sColumnName) const = 0; + + protected: + ~TColumnFindFunctor() {} }; class TExportColumnFindFunctor : public TColumnFindFunctor @@ -66,6 +69,9 @@ namespace dbaui { m_pColumns = _pColumns; } + + virtual ~TExportColumnFindFunctor() {} + inline bool operator()(const ::rtl::OUString& _sColumnName) const { return m_pColumns->find(_sColumnName) != m_pColumns->end(); @@ -83,6 +89,9 @@ namespace dbaui ,m_pVector(_pVector) { } + + virtual ~TMultiListBoxEntryFindFunctor() {} + inline bool operator()(const ::rtl::OUString& _sColumnName) const { return ::std::find_if(m_pVector->begin(),m_pVector->end(), diff --git a/dbaccess/source/ui/inc/adtabdlg.hxx b/dbaccess/source/ui/inc/adtabdlg.hxx index d2d7c6d8a98e..9e8d96fb6bb5 100644 --- a/dbaccess/source/ui/inc/adtabdlg.hxx +++ b/dbaccess/source/ui/inc/adtabdlg.hxx @@ -70,6 +70,9 @@ namespace dbaui virtual bool allowAddition() const = 0; virtual void addTableWindow( const String& _rQualifiedTableName, const String& _rAliasName ) = 0; virtual void onWindowClosing( const Window* _pWindow ) = 0; + + protected: + ~IAddTableDialogContext() {} }; //======================================================================== diff --git a/dbaccess/source/ui/inc/callbacks.hxx b/dbaccess/source/ui/inc/callbacks.hxx index 355e8faafcad..486afba68a0d 100644 --- a/dbaccess/source/ui/inc/callbacks.hxx +++ b/dbaccess/source/ui/inc/callbacks.hxx @@ -73,6 +73,9 @@ namespace dbaui /** execute a drop request */ virtual sal_Int8 executeDrop( const ExecuteDropEvent& _rEvt ) = 0; + + protected: + ~IControlActionListener() {} }; //==================================================================== @@ -108,6 +111,9 @@ namespace dbaui */ virtual ::com::sun::star::uno::Any getCurrentSelection( Control& _rControl ) const = 0; + + protected: + ~IContextMenuProvider() {} }; //==================================================================== @@ -118,6 +124,9 @@ namespace dbaui public: /// called when a drag operation done with a Transferable has been finished virtual void dragFinished( ) = 0; + + protected: + ~IDragTransferableListener() {} }; //........................................................................ diff --git a/dbaccess/source/ui/inc/dbtreelistbox.hxx b/dbaccess/source/ui/inc/dbtreelistbox.hxx index bd40f3a7a0c1..558c66130893 100644 --- a/dbaccess/source/ui/inc/dbtreelistbox.hxx +++ b/dbaccess/source/ui/inc/dbtreelistbox.hxx @@ -51,6 +51,9 @@ namespace dbaui { public: virtual bool includeEntry( SvLBoxEntry* _pEntry ) const = 0; + + protected: + ~IEntryFilter() {} }; //======================================================================== diff --git a/dbaccess/source/ui/inc/sbagrid.hxx b/dbaccess/source/ui/inc/sbagrid.hxx index 344488aad77f..16377165e7b3 100644 --- a/dbaccess/source/ui/inc/sbagrid.hxx +++ b/dbaccess/source/ui/inc/sbagrid.hxx @@ -224,6 +224,9 @@ namespace dbaui virtual void CellDeactivated() = 0; virtual void BeforeDrop() = 0; virtual void AfterDrop() = 0; + + protected: + ~SbaGridListener() {} }; //================================================================== diff --git a/dbaccess/source/ui/misc/dbaundomanager.cxx b/dbaccess/source/ui/misc/dbaundomanager.cxx index 7e34b68835ba..58b83be221a5 100644 --- a/dbaccess/source/ui/misc/dbaundomanager.cxx +++ b/dbaccess/source/ui/misc/dbaundomanager.cxx @@ -120,6 +120,8 @@ namespace dbaui { } + virtual ~OslMutexFacade() {} + virtual void acquire(); virtual void release(); diff --git a/dbaccess/source/ui/querydesign/JoinController.cxx b/dbaccess/source/ui/querydesign/JoinController.cxx index 4008490180f5..1578a950dec5 100644 --- a/dbaccess/source/ui/querydesign/JoinController.cxx +++ b/dbaccess/source/ui/querydesign/JoinController.cxx @@ -100,6 +100,8 @@ public: { } + virtual ~AddTableDialogContext() {} + // IAddTableDialogContext virtual ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XConnection > getConnection() const; |