diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2016-11-08 08:13:11 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2016-11-08 06:57:57 +0000 |
commit | c123c528bf1550e544b29e5a22a94a0452d5f349 (patch) | |
tree | 2dd015a5fe42b6c9b95302016674f3362478d295 /dbaccess | |
parent | tdf#91222 VclBuilder constructor cleanup (diff) | |
download | core-c123c528bf1550e544b29e5a22a94a0452d5f349.tar.gz core-c123c528bf1550e544b29e5a22a94a0452d5f349.zip |
loplugin:unnecessaryvirtual in comphelper..forms
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd
Reviewed-on: https://gerrit.libreoffice.org/30679
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'dbaccess')
-rw-r--r-- | dbaccess/source/ui/inc/ConnectionLine.hxx | 4 | ||||
-rw-r--r-- | dbaccess/source/ui/inc/QueryViewSwitch.hxx | 4 | ||||
-rw-r--r-- | dbaccess/source/ui/inc/RelationControl.hxx | 6 | ||||
-rw-r--r-- | dbaccess/source/ui/inc/brwctrlr.hxx | 4 |
4 files changed, 8 insertions, 10 deletions
diff --git a/dbaccess/source/ui/inc/ConnectionLine.hxx b/dbaccess/source/ui/inc/ConnectionLine.hxx index f8d16a4b1608..5ad17084e20e 100644 --- a/dbaccess/source/ui/inc/ConnectionLine.hxx +++ b/dbaccess/source/ui/inc/ConnectionLine.hxx @@ -36,7 +36,7 @@ namespace dbaui the class OConnectionLine represents the graphical line between the to two windows **/ class OTableConnection; - class OConnectionLine + class OConnectionLine final { VclPtr<OTableConnection> m_pTabConn; OConnectionLineDataRef m_pData; @@ -48,7 +48,7 @@ namespace dbaui public: OConnectionLine( OTableConnection* pConn, OConnectionLineDataRef const & pLineData ); OConnectionLine( const OConnectionLine& rLine ); - virtual ~OConnectionLine(); + ~OConnectionLine(); OConnectionLine& operator=( const OConnectionLine& rLine ); diff --git a/dbaccess/source/ui/inc/QueryViewSwitch.hxx b/dbaccess/source/ui/inc/QueryViewSwitch.hxx index 397a5db5d027..2442b1852a4f 100644 --- a/dbaccess/source/ui/inc/QueryViewSwitch.hxx +++ b/dbaccess/source/ui/inc/QueryViewSwitch.hxx @@ -34,14 +34,14 @@ namespace dbaui class OQueryContainerWindow; class OQueryController; - class OQueryViewSwitch + class OQueryViewSwitch final { VclPtr<OQueryDesignView> m_pDesignView; VclPtr<OQueryTextView> m_pTextView; bool m_bAddTableDialogWasVisible; // true if so public: OQueryViewSwitch(OQueryContainerWindow* pParent, OQueryController& _rController,const css::uno::Reference< css::uno::XComponentContext >& ); - virtual ~OQueryViewSwitch(); + ~OQueryViewSwitch(); bool isCutAllowed(); bool isPasteAllowed(); diff --git a/dbaccess/source/ui/inc/RelationControl.hxx b/dbaccess/source/ui/inc/RelationControl.hxx index 24b9d2dc7b8a..8fe8ed176584 100644 --- a/dbaccess/source/ui/inc/RelationControl.hxx +++ b/dbaccess/source/ui/inc/RelationControl.hxx @@ -30,23 +30,21 @@ namespace dbaui class IRelationControlInterface; class ORelationControl; - class OTableListBoxControl + class OTableListBoxControl final { VclPtr<ListBox> m_pLeftTable; VclPtr<ListBox> m_pRightTable; - VclPtr<ORelationControl> m_pRC_Tables; const OJoinTableView::OTableWindowMap* m_pTableMap; IRelationControlInterface* m_pParentDialog; OUString m_strCurrentLeft; OUString m_strCurrentRight; - private: DECL_LINK( OnTableChanged, ListBox&, void ); public: OTableListBoxControl(VclBuilderContainer* _pParent, const OJoinTableView::OTableWindowMap* _pTableMap, IRelationControlInterface* _pParentDialog); - virtual ~OTableListBoxControl(); + ~OTableListBoxControl(); /** fillListBoxes fills the list boxes with the table windows */ diff --git a/dbaccess/source/ui/inc/brwctrlr.hxx b/dbaccess/source/ui/inc/brwctrlr.hxx index d953491f793b..c227b9d2853e 100644 --- a/dbaccess/source/ui/inc/brwctrlr.hxx +++ b/dbaccess/source/ui/inc/brwctrlr.hxx @@ -113,12 +113,12 @@ namespace dbaui bool m_bCannotSelectUnfiltered : 1; // received an DATA_CANNOT_SELECT_UNFILTERED error protected: - class FormErrorHelper + class FormErrorHelper final { SbaXDataBrowserController* m_pOwner; public: FormErrorHelper(SbaXDataBrowserController* pOwner) : m_pOwner(pOwner) { m_pOwner->enterFormAction(); } - virtual ~FormErrorHelper() { m_pOwner->leaveFormAction(); } + ~FormErrorHelper() { m_pOwner->leaveFormAction(); } }; friend class FormErrorHelper; |