diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-18 08:27:05 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-18 09:46:28 +0200 |
| commit | 5fb66ae5595b7435e8954df31473fad15a74b8c2 (patch) | |
| tree | 3b3f0ce3eafa10557a7e78b10851c97ee16c7ebf /connectivity | |
| parent | xmlsecurity: avoid repeated manual calls to PORT_FreeArena() (diff) | |
| download | core-5fb66ae5595b7435e8954df31473fad15a74b8c2.tar.gz core-5fb66ae5595b7435e8954df31473fad15a74b8c2.zip | |
clang-tidy readability-simplify-boolean-expr
Change-Id: I78fa01a6c803dec782488490b730af3a11814d64
Reviewed-on: https://gerrit.libreoffice.org/61902
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'connectivity')
3 files changed, 3 insertions, 15 deletions
diff --git a/connectivity/source/drivers/firebird/StatementCommonBase.cxx b/connectivity/source/drivers/firebird/StatementCommonBase.cxx index df9b775232e0..03439c937c12 100644 --- a/connectivity/source/drivers/firebird/StatementCommonBase.cxx +++ b/connectivity/source/drivers/firebird/StatementCommonBase.cxx @@ -386,10 +386,7 @@ short OStatementCommonBase::getSqlInfoItem(char aInfoItem) bool OStatementCommonBase::isDDLStatement() { - if (getSqlInfoItem(isc_info_sql_stmt_type) == isc_info_sql_stmt_ddl) - return true; - else - return false; + return getSqlInfoItem(isc_info_sql_stmt_type) == isc_info_sql_stmt_ddl; } sal_Int32 OStatementCommonBase::getStatementChangeCount() diff --git a/connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.cxx b/connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.cxx index 56d82555cedc..e3996f067c7f 100644 --- a/connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.cxx +++ b/connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.cxx @@ -199,12 +199,7 @@ namespace connectivity { sal_Int32 index=static_cast<sal_Int32>(product); ProductStruct &rProduct = m_ProductProfileList[index]; - if (rProduct.mProfileList.empty() || rProduct.mProfileList.find(profileName) == rProduct.mProfileList.end()) - { - return false; - } - else - return true; + return rProduct.mProfileList.find(profileName) != rProduct.mProfileList.end(); } } } diff --git a/connectivity/source/manager/mdrivermanager.cxx b/connectivity/source/manager/mdrivermanager.cxx index ad58f39d85e7..b1824d338efb 100644 --- a/connectivity/source/manager/mdrivermanager.cxx +++ b/connectivity/source/manager/mdrivermanager.cxx @@ -169,11 +169,7 @@ Any SAL_CALL ODriverEnumeration::nextElement( ) bool operator()( const Reference<XDriver>& _rDriver ) const { // ask the driver - if ( _rDriver.is() && _rDriver->acceptsURL( m_rURL ) ) - return true; - - // does not accept ... - return false; + return _rDriver.is() && _rDriver->acceptsURL( m_rURL ); } }; |