diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2016-10-31 11:38:49 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2016-10-31 11:38:49 +0100 |
| commit | 7441141bcffe43c7cad3795f2979270328028917 (patch) | |
| tree | 88ef722c09670aac0dcd72a0e2e420dc3df2d57b /compilerplugins | |
| parent | SvxBrushItem::GetGraphicLink no longer returns a pointer (diff) | |
| download | core-7441141bcffe43c7cad3795f2979270328028917.tar.gz core-7441141bcffe43c7cad3795f2979270328028917.zip | |
No good reason for dbaccess::OCacheSet::updateRow to be pure?
Most of its virtual member functions are (though insertRow is already a curious
exception), even though they are defined, so smells like a copy/paste error
rather than deliberate design. And appears to have been the only reason why
loplugin:unnecessaryoverride filtered out such overriding of pure base
functions.
Change-Id: Ib2a40af9cd3cd3dbb26c4147f7d01de4e11f5f6e
Diffstat (limited to 'compilerplugins')
| -rw-r--r-- | compilerplugins/clang/unnecessaryoverride.cxx | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/compilerplugins/clang/unnecessaryoverride.cxx b/compilerplugins/clang/unnecessaryoverride.cxx index fedea345ca93..96da48c339bd 100644 --- a/compilerplugins/clang/unnecessaryoverride.cxx +++ b/compilerplugins/clang/unnecessaryoverride.cxx @@ -80,8 +80,7 @@ bool UnnecessaryOverride::VisitCXXMethodDecl(const CXXMethodDecl* methodDecl) // if we are overriding more than one method, then this is a disambiguating override if (methodDecl->isVirtual()) { - if (methodDecl->size_overridden_methods() != 1 - || (*methodDecl->begin_overridden_methods())->isPure()) + if (methodDecl->size_overridden_methods() != 1) { return true; } |