diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-07-13 10:50:22 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-07-13 11:58:10 +0200 |
commit | dbf8ad9bc385411c349095dfa66345464b4215d6 (patch) | |
tree | 507ac08bf144fa8ac44ad4889ce127cb0d0c70c7 /compilerplugins/clang/useuniqueptr.cxx | |
parent | tdf#118702: partially revert the fix for tdf#78907 (diff) | |
download | core-dbf8ad9bc385411c349095dfa66345464b4215d6.tar.gz core-dbf8ad9bc385411c349095dfa66345464b4215d6.zip |
loplugin:useuniqueptr in SbUnoStructRefObject
now that we have upgraded to VS2017, we can use std::unique_ptr in
std::map
Change-Id: Id01af07ccae7447405b8f0bc44b08043f453e54b
Reviewed-on: https://gerrit.libreoffice.org/57384
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'compilerplugins/clang/useuniqueptr.cxx')
-rw-r--r-- | compilerplugins/clang/useuniqueptr.cxx | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/compilerplugins/clang/useuniqueptr.cxx b/compilerplugins/clang/useuniqueptr.cxx index 0af8cd295a6b..0520546052a4 100644 --- a/compilerplugins/clang/useuniqueptr.cxx +++ b/compilerplugins/clang/useuniqueptr.cxx @@ -288,10 +288,7 @@ void UseUniquePtr::CheckDeleteExpr(const CXXMethodDecl* methodDecl, const CXXDel // the std::vector is being passed to another class if (loplugin::isSamePathname(aFileName, SRCDIR "/sfx2/source/explorer/nochaos.cxx")) return; - // ignore std::map and std::unordered_map, MSVC 2015 has problems with mixing these with std::unique_ptr auto tc = loplugin::TypeCheck(fieldDecl->getType()); - if (tc.Class("map").StdNamespace() || tc.Class("unordered_map").StdNamespace()) - return; // these sw::Ring based classes do not lend themselves to std::unique_ptr management if (tc.Pointer().Class("SwNodeIndex").GlobalNamespace() || tc.Pointer().Class("SwShellTableCursor").GlobalNamespace() || tc.Pointer().Class("SwBlockCursor").GlobalNamespace() || tc.Pointer().Class("SwVisibleCursor").GlobalNamespace() |