loplugin:unusedmethods

most of the removal is ripple effect from removing
SvxIconChoiceCtrl_Impl::EditEntry
which became dead after
commit 630b5db9a10cd49d24d5e563374bd68f1fe670f5
Date:   Tue Nov 13 08:40:07 2018 +0200
loplugin:singlevalfields in svtools

Change-Id: Ibfaa7c925cc5549a4858cc62c59d848aab72f460
Reviewed-on: https://gerrit.libreoffice.org/63481
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 28 insertions, 24 deletions

diff --git a/compilerplugins/clang/unusedmethods.unused-returns.results b/compilerplugins/clang/unusedmethods.unused-returns.results
index 5c0195a00c5d..60f3f7f5c82f 100644
--- a/compilerplugins/clang/unusedmethods.unused-returns.results
+++ b/compilerplugins/clang/unusedmethods.unused-returns.results
@@ -42,31 +42,31 @@ include/LibreOfficeKit/LibreOfficeKit.hxx:97
     char * lok::Document::getPartPageRectangles()
 include/LibreOfficeKit/LibreOfficeKit.hxx:121
     char * lok::Document::getPartHash(int)
-include/LibreOfficeKit/LibreOfficeKit.hxx:342
+include/LibreOfficeKit/LibreOfficeKit.hxx:349
     char * lok::Document::getTextSelection(const char *,char **)
-include/LibreOfficeKit/LibreOfficeKit.hxx:354
+include/LibreOfficeKit/LibreOfficeKit.hxx:361
     _Bool lok::Document::paste(const char *,const char *,unsigned long)
-include/LibreOfficeKit/LibreOfficeKit.hxx:385
+include/LibreOfficeKit/LibreOfficeKit.hxx:392
     char * lok::Document::getCommandValues(const char *)
-include/LibreOfficeKit/LibreOfficeKit.hxx:467
+include/LibreOfficeKit/LibreOfficeKit.hxx:474
     int lok::Document::getView()
-include/LibreOfficeKit/LibreOfficeKit.hxx:475
+include/LibreOfficeKit/LibreOfficeKit.hxx:482
     int lok::Document::getViewsCount()
-include/LibreOfficeKit/LibreOfficeKit.hxx:484
+include/LibreOfficeKit/LibreOfficeKit.hxx:491
     unsigned char * lok::Document::renderFont(const char *,const char *,int *,int *)
-include/LibreOfficeKit/LibreOfficeKit.hxx:523
+include/LibreOfficeKit/LibreOfficeKit.hxx:530
     _Bool lok::Document::getViewIds(int *,unsigned long)
-include/LibreOfficeKit/LibreOfficeKit.hxx:584
+include/LibreOfficeKit/LibreOfficeKit.hxx:591
     _Bool lok::Document::insertCertificate(const unsigned char *,const int,const unsigned char *,const int)
-include/LibreOfficeKit/LibreOfficeKit.hxx:598
+include/LibreOfficeKit/LibreOfficeKit.hxx:605
     _Bool lok::Document::addCertificate(const unsigned char *,const int)
-include/LibreOfficeKit/LibreOfficeKit.hxx:610
+include/LibreOfficeKit/LibreOfficeKit.hxx:617
     int lok::Document::getSignatureState()
-include/LibreOfficeKit/LibreOfficeKit.hxx:705
+include/LibreOfficeKit/LibreOfficeKit.hxx:712
     char * lok::Office::getFilterTypes()
-include/LibreOfficeKit/LibreOfficeKit.hxx:759
+include/LibreOfficeKit/LibreOfficeKit.hxx:766
     char * lok::Office::getVersionInfo()
-include/LibreOfficeKit/LibreOfficeKit.hxx:773
+include/LibreOfficeKit/LibreOfficeKit.hxx:780
     _Bool lok::Office::runMacro(const char *)
 include/oox/crypto/AgileEngine.hxx:121
     _Bool oox::core::AgileEngine::decryptHmacKey()
@@ -152,7 +152,7 @@ include/sfx2/lnkbase.hxx:103
     class sfx2::SvLinkSource * sfx2::SvBaseLink::GetRealObject()
 include/svl/macitem.hxx:92
     class SvStream & SvxMacroTableDtor::Write(class SvStream &) const
-include/svl/poolitem.hxx:173
+include/svl/poolitem.hxx:169
     class SvStream & SfxPoolItem::Store(class SvStream &,unsigned short) const
 include/svx/dlgctrl.hxx:105
     class Point SvxRectCtl::SetActualRPWithoutInvalidate(enum RectPoint)
@@ -172,7 +172,7 @@ include/test/sheet/xspreadsheets2.hxx:40
     class com::sun::star::uno::Reference<class com::sun::star::lang::XComponent> apitest::XSpreadsheets2::getComponent()
 include/test/sheet/xstyleloader.hxx:27
     class com::sun::star::uno::Reference<class com::sun::star::lang::XComponent> apitest::XStyleLoader::getTargetComponent()
-include/test/sheet/xusedareacursor.hxx:25
+include/test/sheet/xusedareacursor.hxx:22
     class com::sun::star::uno::Reference<class com::sun::star::uno::XInterface> apitest::XUsedAreaCursor::init()
 include/tools/color.hxx:151
     class SvStream & Color::Read(class SvStream &)
@@ -202,9 +202,9 @@ include/vcl/texteng.hxx:279
     _Bool TextEngine::Read(class SvStream &,const class TextSelection *)
 include/vcl/toolbox.hxx:514
     _Bool ToolBox::ChangeHighlightUpDn(_Bool)
-include/vcl/weld.hxx:355
+include/vcl/weld.hxx:357
     _Bool weld::ComboBox::get_entry_selection_bounds(int &,int &)
-include/vcl/weld.hxx:1033
+include/vcl/weld.hxx:1059
     _Bool weld::TextView::get_selection_bounds(int &,int &)
 lotuswordpro/inc/lwpsvstream.hxx:76
     class LwpSvStream & LwpSvStream::ReadUInt8(unsigned char &)
@@ -212,15 +212,17 @@ lotuswordpro/inc/lwpsvstream.hxx:77
     class LwpSvStream & LwpSvStream::ReadUInt16(unsigned short &)
 lotuswordpro/inc/lwpsvstream.hxx:78
     class LwpSvStream & LwpSvStream::ReadUInt32(unsigned int &)
+sc/inc/document.hxx:2107
+    const struct ScDocumentThreadSpecific & ScDocument::CalculateInColumnInThread(struct ScInterpreterContext &,const class ScAddress &,unsigned long,unsigned int,unsigned int)
 sc/inc/orcusfilters.hxx:44
     _Bool ScOrcusFilters::importODS_Styles(class ScDocument &,class rtl::OUString &) const
-sc/source/core/opencl/formulagroupcl.cxx:990
+sc/source/core/opencl/formulagroupcl.cxx:997
     unsigned long sc::opencl::DynamicKernelSlidingArgument::GenReductionLoopHeader(class std::__cxx11::basic_stringstream<char> &,_Bool &)
-sc/source/core/opencl/formulagroupcl.cxx:1230
+sc/source/core/opencl/formulagroupcl.cxx:1237
     unsigned long sc::opencl::ParallelReductionVectorRef::GenReductionLoopHeader(class std::__cxx11::basic_stringstream<char> &,int,_Bool &)
 sc/source/filter/inc/workbookhelper.hxx:259
     _Bool oox::xls::WorkbookHelper::importOoxFragment(const class rtl::Reference<class oox::core::FragmentHandler> &,class oox::core::FastParser &)
-sc/source/filter/xml/XMLStylesExportHelper.hxx:179
+sc/source/filter/xml/XMLStylesExportHelper.hxx:178
     _Bool ScFormatRangeStyles::AddStyleName(const class rtl::OUString &,int &,const _Bool)
 sc/source/ui/inc/select.hxx:72
     _Bool ScViewFunctionSet::SetCursorAtCell(short,int,_Bool)
@@ -264,9 +266,9 @@ sd/source/ui/remotecontrol/IBluetoothSocket.hxx:37
     int sd::IBluetoothSocket::write(const void *,unsigned int)
 sw/inc/calc.hxx:113
     class SwSbxValue & SwSbxValue::MakeDouble()
-sw/inc/doc.hxx:1063
+sw/inc/doc.hxx:1066
     _Bool SwDoc::ReplaceNumRule(const struct SwPosition &,const class rtl::OUString &,const class rtl::OUString &)
-sw/inc/doc.hxx:1245
+sw/inc/doc.hxx:1252
     _Bool SwDoc::SplitTable(const struct SwPosition &,enum SplitTable_HeadlineOption,_Bool)
 sw/inc/editsh.hxx:264
     _Bool SwEditShell::GetPaMParAttr(class SwPaM *,class SfxItemSet &) const
@@ -304,14 +306,16 @@ vcl/inc/opengl/texture.hxx:112
     _Bool OpenGLTexture::CopyData(int,int,int,int,const unsigned char *)
 vcl/inc/salframe.hxx:222
     _Bool SalFrame::SetPluginParent(struct SystemParentData *)
-vcl/inc/salgdi.hxx:211
+vcl/inc/salgdi.hxx:212
     class basegfx::B2DPoint SalGraphics::mirror(const class basegfx::B2DPoint &,const class OutputDevice *) const
-vcl/inc/salgdi.hxx:394
+vcl/inc/salgdi.hxx:395
     _Bool SalGraphics::BlendBitmap(const struct SalTwoRect &,const class SalBitmap &,const class OutputDevice *)
 vcl/inc/unx/gtk/gtkdata.hxx:164
     int GtkSalDisplay::CaptureMouse(class SalFrame *)
 vcl/inc/unx/saldisp.hxx:316
     _Bool SalDisplay::Dispatch(union _XEvent *)
+vcl/inc/WidgetDrawInterface.hxx:97
+    _Bool vcl::WidgetDrawInterface::updateSettings(class AllSettings &)
 vcl/source/gdi/pdfwriter_impl.hxx:1230
     _Bool vcl::PDFWriterImpl::setCurrentStructureElement(int)
 vcl/source/gdi/pdfwriter_impl.hxx:1231