diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2018-03-23 10:49:57 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2018-03-23 13:02:23 +0100 |
| commit | 119d8137695e38c16e9fad9f3ce8a774f58e4b9a (patch) | |
| tree | 9003666348a5cbd45b7ac1ee57a3471192175e57 /compilerplugins/clang/plugin.hxx | |
| parent | use boost::optional in vcl (diff) | |
| download | core-119d8137695e38c16e9fad9f3ce8a774f58e4b9a.tar.gz core-119d8137695e38c16e9fad9f3ce8a774f58e4b9a.zip | |
Revert "Allow compiler plugins for online"
This reverts commit b39e627be45f847554f11fdac040b6f4da4054ba. The assumed (see
comment at <https://gerrit.libreoffice.org/#/c/46769/4/compilerplugins/clang/
plugin.cxx@633>) performance bottleneck of isSamePathname -> getAbsolutePath
does show up in Flamegraph inspections of LO builds. But changing (non-member
function) isSamePathname to only call getAbsolutePath if (PluginHandlder member
function) isLOOLMode is true would need some code reorg, and Online development
doesn't seem to make too much actual use of the plugin, so conclusion on IRC was
to revert.
Change-Id: I0f04fdcc87087dac516630ed5e48361f5ea332ca
Reviewed-on: https://gerrit.libreoffice.org/51774
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'compilerplugins/clang/plugin.hxx')
| -rw-r--r-- | compilerplugins/clang/plugin.hxx | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/compilerplugins/clang/plugin.hxx b/compilerplugins/clang/plugin.hxx index 95983c00060d..5299e7f2eac3 100644 --- a/compilerplugins/clang/plugin.hxx +++ b/compilerplugins/clang/plugin.hxx @@ -80,7 +80,6 @@ protected: bool isInUnoIncludeFile(const FunctionDecl*) const; bool isDebugMode() const { return handler.isDebugMode(); } - bool isLOOLMode() const { return handler.isLOOLMode(); } static bool isUnitTestMode(); @@ -230,9 +229,6 @@ void normalizeDotDotInFilePath(std::string&); // prefix may also contain backslashes: bool hasPathnamePrefix(StringRef pathname, StringRef prefix); -// get the absolute path for a given path -std::string getAbsolutePath(StringRef path); - // Same as pathname == other, except on Windows, where pathname and other may // also contain backslashes: bool isSamePathname(StringRef pathname, StringRef other); |