summaryrefslogtreecommitdiffstats
path: root/codemaker/source/cppumaker
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2018-10-16 15:23:12 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2018-10-17 08:25:47 +0200
commitccb2a1f650bc505f8a4f1abebf8ce4f9396562a8 (patch)
tree2ee2fd4f300ae95cf23bade1f242e02f9b276c07 /codemaker/source/cppumaker
parentloplugin:staticvar in avmedia..connectivity (diff)
downloadcore-ccb2a1f650bc505f8a4f1abebf8ce4f9396562a8.tar.gz
core-ccb2a1f650bc505f8a4f1abebf8ce4f9396562a8.zip
clang-tidy readability-redundant-smartptr-get
redundant get() call on smart pointer Change-Id: Icb5a03bbc15e79a30d3d135a507d22914d15c2bd Reviewed-on: https://gerrit.libreoffice.org/61837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'codemaker/source/cppumaker')
-rw-r--r--codemaker/source/cppumaker/cpputype.cxx16
1 files changed, 5 insertions, 11 deletions
diff --git a/codemaker/source/cppumaker/cpputype.cxx b/codemaker/source/cppumaker/cpputype.cxx
index 722846b0efa6..4b3face0c702 100644
--- a/codemaker/source/cppumaker/cpputype.cxx
+++ b/codemaker/source/cppumaker/cpputype.cxx
@@ -736,9 +736,7 @@ OUString CppuType::getTypeClass(OUString const & name, bool cStyle)
? OUString("typelib_TypeClass_INTERFACE")
: OUString("::css::uno::TypeClass_INTERFACE");
case codemaker::UnoType::Sort::Typedef:
- return getTypeClass(
- dynamic_cast<unoidl::TypedefEntity&>(*ent.get()).getType(),
- cStyle);
+ return getTypeClass(dynamic_cast<unoidl::TypedefEntity&>(*ent).getType(), cStyle);
default:
for (;;) {
std::abort();
@@ -988,7 +986,7 @@ OUString CppuType::resolveOuterTypedefs(OUString const & name) const
if (m_typeMgr->getSort(n, &ent) != codemaker::UnoType::Sort::Typedef) {
return n;
}
- n = dynamic_cast<unoidl::TypedefEntity&>(*ent.get()).getType();
+ n = dynamic_cast<unoidl::TypedefEntity&>(*ent).getType();
}
}
@@ -1002,11 +1000,8 @@ OUString CppuType::resolveAllTypedefs(OUString const & name) const
break;
}
sal_Int32 k2;
- n = b2u(
- codemaker::UnoType::decompose(
- u2b(dynamic_cast<unoidl::TypedefEntity&>(*ent.get()).
- getType()),
- &k2));
+ n = b2u(codemaker::UnoType::decompose(
+ u2b(dynamic_cast<unoidl::TypedefEntity&>(*ent).getType()), &k2));
k1 += k2; //TODO: overflow
}
OUStringBuffer b;
@@ -3138,8 +3133,7 @@ sal_uInt32 ExceptionType::getTotalMemberCount(OUString const & base) const
throw CannotDumpException(
"exception type base " + base + " is not an exception type");
}
- unoidl::ExceptionTypeEntity& ent2(
- dynamic_cast< unoidl::ExceptionTypeEntity&>(*ent.get()));
+ unoidl::ExceptionTypeEntity& ent2(dynamic_cast<unoidl::ExceptionTypeEntity&>(*ent));
return getTotalMemberCount(ent2.getDirectBase())
+ ent2.getDirectMembers().size(); //TODO: overflow
}