diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-07-05 08:32:57 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-07-05 11:08:48 +0200 |
| commit | 4b2262ab5b10f334f1984fec84d2978db81c58f1 (patch) | |
| tree | de56663eba6ed2edf7a26127339dd8563fdf47be /chart2 | |
| parent | tdf#108919: Fix WID, should be EE_PARA_JUST instead of 0 (diff) | |
| download | core-4b2262ab5b10f334f1984fec84d2978db81c58f1.tar.gz core-4b2262ab5b10f334f1984fec84d2978db81c58f1.zip | |
new loplugin unnecessaryparen
Change-Id: Ic883a07b30069ca6342d7521c8ad890f4326f0ec
Reviewed-on: https://gerrit.libreoffice.org/39549
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'chart2')
4 files changed, 10 insertions, 14 deletions
diff --git a/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx b/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx index c7cc2cf856da..c37e9f67c80b 100644 --- a/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx +++ b/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx @@ -175,7 +175,7 @@ void WrappedScaleProperty::setPropertyValue( tScaleProperty eScaleProperty, cons rSubIncrements.realloc( 1 ); double fStepHelp = 0; - if( (rOuterValue >>= fStepHelp) ) + if( rOuterValue >>= fStepHelp ) { double fStepMain = 0; if( AxisHelper::isLogarithmic(aScaleData.Scaling) ) @@ -265,7 +265,7 @@ void WrappedScaleProperty::setPropertyValue( tScaleProperty eScaleProperty, cons case SCALE_PROP_AXIS_TYPE: { sal_Int32 nType = 0; - if( (rOuterValue >>= nType) ) + if( rOuterValue >>= nType ) { if( nType == css::chart::ChartAxisType::AUTOMATIC ) { diff --git a/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx b/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx index 629600d33625..ccd9bd099910 100644 --- a/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx +++ b/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx @@ -475,8 +475,7 @@ bool AxisItemConverter::ApplySpecialItem( sal_uInt16 nWhichId, const SfxItemSet switch( nWhichId ) { case SCHATTR_AXIS_AUTO_MAX: - if( (static_cast< const SfxBoolItem & >( - rItemSet.Get( nWhichId )).GetValue() )) + if( static_cast< const SfxBoolItem & >(rItemSet.Get( nWhichId )).GetValue() ) { aScale.Maximum.clear(); bSetScale = true; @@ -500,8 +499,7 @@ bool AxisItemConverter::ApplySpecialItem( sal_uInt16 nWhichId, const SfxItemSet break; case SCHATTR_AXIS_AUTO_MIN: - if( (static_cast< const SfxBoolItem & >( - rItemSet.Get( nWhichId )).GetValue() )) + if( static_cast< const SfxBoolItem & >(rItemSet.Get( nWhichId )).GetValue() ) { aScale.Minimum.clear(); bSetScale = true; @@ -528,8 +526,7 @@ bool AxisItemConverter::ApplySpecialItem( sal_uInt16 nWhichId, const SfxItemSet { bool bWasLogarithm = AxisHelper::isLogarithmic( aScale.Scaling ); - if( (static_cast< const SfxBoolItem & >( - rItemSet.Get( nWhichId )).GetValue() )) + if( static_cast< const SfxBoolItem & >(rItemSet.Get( nWhichId )).GetValue() ) { // logarithm is true if( ! bWasLogarithm ) @@ -673,7 +670,7 @@ bool AxisItemConverter::ApplySpecialItem( sal_uInt16 nWhichId, const SfxItemSet break; case SCHATTR_AXIS_AUTO_TIME_RESOLUTION: - if( (static_cast< const SfxBoolItem & >( rItemSet.Get( nWhichId )).GetValue() )) + if( static_cast< const SfxBoolItem & >( rItemSet.Get( nWhichId )).GetValue() ) { aScale.TimeIncrement.TimeResolution.clear(); bSetScale = true; @@ -695,8 +692,7 @@ bool AxisItemConverter::ApplySpecialItem( sal_uInt16 nWhichId, const SfxItemSet case SCHATTR_AXIS_AUTO_ORIGIN: { - if( (static_cast< const SfxBoolItem & >( - rItemSet.Get( nWhichId )).GetValue() )) + if( static_cast< const SfxBoolItem & >(rItemSet.Get( nWhichId )).GetValue() ) { aScale.Origin.clear(); bSetScale = true; diff --git a/chart2/source/controller/itemsetwrapper/ErrorBarItemConverter.cxx b/chart2/source/controller/itemsetwrapper/ErrorBarItemConverter.cxx index b37123747c28..56a5e047454f 100644 --- a/chart2/source/controller/itemsetwrapper/ErrorBarItemConverter.cxx +++ b/chart2/source/controller/itemsetwrapper/ErrorBarItemConverter.cxx @@ -258,8 +258,8 @@ bool ErrorBarItemConverter::ApplySpecialItem( bool bShowPos(false), bShowNeg(false); lcl_getErrorIndicatorValues( xErrorBarProp, bShowPos, bShowNeg ); - if( ( bShowPos != bNewIndPos || - bShowNeg != bNewIndNeg )) + if( bShowPos != bNewIndPos || + bShowNeg != bNewIndNeg ) { xErrorBarProp->setPropertyValue( "ShowPositiveError" , uno::Any( bNewIndPos )); xErrorBarProp->setPropertyValue( "ShowNegativeError" , uno::Any( bNewIndNeg )); diff --git a/chart2/source/view/charttypes/GL3DBarChart.cxx b/chart2/source/view/charttypes/GL3DBarChart.cxx index 8a91a62ef1f9..1eecec9f67f9 100644 --- a/chart2/source/view/charttypes/GL3DBarChart.cxx +++ b/chart2/source/view/charttypes/GL3DBarChart.cxx @@ -1464,7 +1464,7 @@ void GL3DBarChart::processAutoFly(sal_uInt32 nId, sal_uInt32 nColor) sal_uInt32 nPreColor = maBarColorMap[nId]; maBarColorMap[nId] = nColor; //if has manul event, just record the color and process manul event first - if ((maRenderEvent != EVENT_NONE)) + if (maRenderEvent != EVENT_NONE) { return; } |