diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-07-19 09:50:11 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-07-19 11:31:51 +0200 |
| commit | 836c40904f4424a5b7ae708171a7aab53141761a (patch) | |
| tree | 5f84c7b9d57aface755ef6f4b11ccc1deb1da9c6 /chart2/source/controller/dialogs/tp_ChartType.cxx | |
| parent | cid#1448351 Use after free (diff) | |
| download | core-836c40904f4424a5b7ae708171a7aab53141761a.tar.gz core-836c40904f4424a5b7ae708171a7aab53141761a.zip | |
loplugin:referencecasting in canvas..chart2
Change-Id: I3a3671b5c44d1a7e5ca320d3d76dd5d902382cbc
Reviewed-on: https://gerrit.libreoffice.org/75935
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'chart2/source/controller/dialogs/tp_ChartType.cxx')
| -rw-r--r-- | chart2/source/controller/dialogs/tp_ChartType.cxx | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/chart2/source/controller/dialogs/tp_ChartType.cxx b/chart2/source/controller/dialogs/tp_ChartType.cxx index 602b2d6b2858..fd4710151511 100644 --- a/chart2/source/controller/dialogs/tp_ChartType.cxx +++ b/chart2/source/controller/dialogs/tp_ChartType.cxx @@ -613,7 +613,7 @@ ChartTypeTabPage::ChartTypeTabPage(TabPageParent pParent , const uno::Reference< , m_aChartTypeDialogControllerList(0) , m_pCurrentMainType(nullptr) , m_nChangingCalls(0) - , m_aTimerTriggeredControllerLock( uno::Reference< frame::XModel >( m_xChartModel, uno::UNO_QUERY ) ) + , m_aTimerTriggeredControllerLock( m_xChartModel ) , m_xFT_ChooseType(m_xBuilder->weld_label("FT_CAPTION_FOR_WIZARD")) , m_xMainTypeList(m_xBuilder->weld_tree_view("charttype")) , m_xSubTypeList(new SvtValueSet(m_xBuilder->weld_scrolled_window("subtypewin"))) @@ -867,8 +867,7 @@ void ChartTypeTabPage::initializePage() if( !m_xChartModel.is() ) return; uno::Reference< lang::XMultiServiceFactory > xTemplateManager( m_xChartModel->getChartTypeManager(), uno::UNO_QUERY ); - uno::Reference< frame::XModel > xModel( m_xChartModel, uno::UNO_QUERY); - uno::Reference< XDiagram > xDiagram( ChartModelHelper::findDiagram( xModel ) ); + uno::Reference< XDiagram > xDiagram( ChartModelHelper::findDiagram( m_xChartModel ) ); DiagramHelper::tTemplateWithServiceName aTemplate = DiagramHelper::getTemplateForDiagram( xDiagram, xTemplateManager ); OUString aServiceName( aTemplate.second ); |