diff options
| author | Mike Kaganski <mike.kaganski@collabora.com> | 2018-12-02 01:14:15 +0300 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2018-12-02 05:31:19 +0100 |
| commit | 4da61d4cc8f70ff62d7bac23a1b97d9d7011a678 (patch) | |
| tree | 46473e2819f4d98a7f82a3a814b1fb521e925373 /canvas | |
| parent | tdf#120703 PVS: V560 A part of conditional expression is always true/false (diff) | |
| download | core-4da61d4cc8f70ff62d7bac23a1b97d9d7011a678.tar.gz core-4da61d4cc8f70ff62d7bac23a1b97d9d7011a678.zip | |
tdf#120703 PVS: logical AND had been used instead of bitwise
V560 A part of conditional expression is always true:
sal_Int32(0xFF) != 0.
Change-Id: I5f19c4ff20e91767d22a85239f9693d68ff360b1
Reviewed-on: https://gerrit.libreoffice.org/64414
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'canvas')
| -rw-r--r-- | canvas/source/simplecanvas/simplecanvasimpl.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/canvas/source/simplecanvas/simplecanvasimpl.cxx b/canvas/source/simplecanvas/simplecanvasimpl.cxx index fe558b0a8886..2e38ee8ffc2b 100644 --- a/canvas/source/simplecanvas/simplecanvasimpl.cxx +++ b/canvas/source/simplecanvas/simplecanvasimpl.cxx @@ -112,7 +112,7 @@ namespace private: bool isStrokingEnabled() const { - return maRenderState.m_aPenColor.getInValue() && sal_Int32(0xFF) != 0; + return maRenderState.m_aPenColor.getInValue() % 0x100 != 0; } rendering::RenderState createStrokingRenderState() const @@ -125,7 +125,7 @@ namespace bool isFillingEnabled() const { - return maRenderState.m_aFillColor.getInValue() && sal_Int32(0xFF) != 0; + return maRenderState.m_aFillColor.getInValue() % 0x100 != 0; } rendering::RenderState createFillingRenderState() const |