diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-07-28 11:47:51 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-07-28 14:51:56 +0200 |
| commit | b09deb075319c1c19f91e3a6f64429b61682ebf8 (patch) | |
| tree | 9e73d1e63092083a337a4ddf1dfe962b4f6ef4dc /basic | |
| parent | sw htmlexport: Avoid unnecessary conversion to base64 + unit tests. (diff) | |
| download | core-b09deb075319c1c19f91e3a6f64429b61682ebf8.tar.gz core-b09deb075319c1c19f91e3a6f64429b61682ebf8.zip | |
loplugin:constparams handle constructors
had to change the structure of the plugin considerably, was too messy to
structure it to do the calculations on a per-function basis
Change-Id: I4edee7735f726101105c607368124a08dba21086
Reviewed-on: https://gerrit.libreoffice.org/40516
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'basic')
| -rw-r--r-- | basic/source/basmgr/basmgr.cxx | 4 | ||||
| -rw-r--r-- | basic/source/runtime/iosys.cxx | 8 |
2 files changed, 6 insertions, 6 deletions
diff --git a/basic/source/basmgr/basmgr.cxx b/basic/source/basmgr/basmgr.cxx index 9189d7538df8..823e2a04fd63 100644 --- a/basic/source/basmgr/basmgr.cxx +++ b/basic/source/basmgr/basmgr.cxx @@ -438,7 +438,7 @@ BasicLibInfo* BasicLibInfo::Create( SotStorageStream& rSStream ) return pInfo; } -BasicManager::BasicManager( SotStorage& rStorage, const OUString& rBaseURL, StarBASIC* pParentFromStdLib, OUString* pLibPath, bool bDocMgr ) : mbDocMgr( bDocMgr ) +BasicManager::BasicManager( SotStorage& rStorage, const OUString& rBaseURL, StarBASIC* pParentFromStdLib, OUString const * pLibPath, bool bDocMgr ) : mbDocMgr( bDocMgr ) { Init(); @@ -604,7 +604,7 @@ void BasicManager::SetLibraryContainerInfo( const LibraryContainerInfo& rInfo ) SetGlobalUNOConstant( "DialogLibraries", uno::Any( mpImpl->maContainerInfo.mxDialogCont ) ); } -BasicManager::BasicManager( StarBASIC* pSLib, OUString* pLibPath, bool bDocMgr ) : mbDocMgr( bDocMgr ) +BasicManager::BasicManager( StarBASIC* pSLib, OUString const * pLibPath, bool bDocMgr ) : mbDocMgr( bDocMgr ) { Init(); DBG_ASSERT( pSLib, "BasicManager cannot be created with a NULL-Pointer!" ); diff --git a/basic/source/runtime/iosys.cxx b/basic/source/runtime/iosys.cxx index 11c2806a4632..ab9a333ad5a8 100644 --- a/basic/source/runtime/iosys.cxx +++ b/basic/source/runtime/iosys.cxx @@ -292,8 +292,8 @@ class UCBStream : public SvStream Reference< XStream > xS; Reference< XSeekable > xSeek; public: - explicit UCBStream( Reference< XInputStream > & xIS ); - explicit UCBStream( Reference< XStream > & xS ); + explicit UCBStream( Reference< XInputStream > const & xIS ); + explicit UCBStream( Reference< XStream > const & xS ); virtual ~UCBStream() override; virtual std::size_t GetData( void* pData, std::size_t nSize ) override; virtual std::size_t PutData( const void* pData, std::size_t nSize ) override; @@ -302,13 +302,13 @@ public: virtual void SetSize( sal_uInt64 nSize ) override; }; -UCBStream::UCBStream( Reference< XInputStream > & rStm ) +UCBStream::UCBStream( Reference< XInputStream > const & rStm ) : xIS( rStm ) , xSeek( rStm, UNO_QUERY ) { } -UCBStream::UCBStream( Reference< XStream > & rStm ) +UCBStream::UCBStream( Reference< XStream > const & rStm ) : xS( rStm ) , xSeek( rStm, UNO_QUERY ) { |