summaryrefslogtreecommitdiffstats
path: root/avmedia
diff options
context:
space:
mode:
authorJulien Nabet <serval2412@yahoo.fr>2019-07-04 18:09:26 +0200
committerMichael Stahl <Michael.Stahl@cib.de>2019-07-05 10:56:51 +0200
commit280016e6c7df52de040e3b086747237bb9d84e2c (patch)
treefd43f4b90faaa7467235c0843b787ebe50048ac5 /avmedia
parentRevert "Colibre, Breeze, elementary, KJ: tdf#107144, Breeze: tdf#126233" (diff)
downloadcore-280016e6c7df52de040e3b086747237bb9d84e2c.tar.gz
core-280016e6c7df52de040e3b086747237bb9d84e2c.zip
cid#1448380: Resource leak (avmedia/gstplayer)
Change-Id: Ieaf5f68f17558f27e187241869c8fe01f8e29ba2 Reviewed-on: https://gerrit.libreoffice.org/75100 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Diffstat (limited to 'avmedia')
-rw-r--r--avmedia/source/gstreamer/gstplayer.cxx5
1 files changed, 2 insertions, 3 deletions
diff --git a/avmedia/source/gstreamer/gstplayer.cxx b/avmedia/source/gstreamer/gstplayer.cxx
index 0236f7895b8c..0871ecd2ea53 100644
--- a/avmedia/source/gstreamer/gstplayer.cxx
+++ b/avmedia/source/gstreamer/gstplayer.cxx
@@ -939,10 +939,9 @@ uno::Reference< ::media::XPlayerWindow > SAL_CALL Player::createPlayerWindow( co
if( aSize.Width > 0 && aSize.Height > 0 )
{
- ::avmedia::gstreamer::Window* pWindow = new ::avmedia::gstreamer::Window;
if (rArguments.getLength() <= 2)
{
- xRet = pWindow;
+ xRet = new ::avmedia::gstreamer::Window;
return xRet;
}
@@ -986,7 +985,7 @@ uno::Reference< ::media::XPlayerWindow > SAL_CALL Player::createPlayerWindow( co
return nullptr;
}
- xRet = pWindow;
+ xRet = new ::avmedia::gstreamer::Window;
g_object_set(G_OBJECT(mpPlaybin), "video-sink", pVideosink, nullptr);
g_object_set(G_OBJECT(mpPlaybin), "force-aspect-ratio", FALSE, nullptr);