Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 5

- Revise uses of getSomething to use getFromUnoTunnel

Where that is impossible, use getSomething_cast to unify casting,
and minimize number of places doing low-level transformations.

The change keeps the existing tunnel references that last for the
duration of the pointers' life, because sometimes destroying such
reference may destroy the pointed object, and result in use after
free.

Change-Id: I291c33223582c34cd2c763aa8aacf0ae899ca4c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122101
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

1 files changed, 1 insertions, 5 deletions

diff --git a/animations/source/animcore/animcore.cxx b/animations/source/animcore/animcore.cxx
index 71d4ab97e9e2..b664b683347a 100644
--- a/animations/source/animcore/animcore.cxx
+++ b/animations/source/animcore/animcore.cxx
@@ -1221,11 +1221,7 @@ void SAL_CALL AnimationNode::setParent( const Reference< XInterface >& Parent )
     if( Parent != mxParent.get() )
     {
         mxParent = Parent;
-
-        mpParent = nullptr;
-        Reference< XUnoTunnel > xTunnel( mxParent.get(), UNO_QUERY );
-        if( xTunnel.is() )
-            mpParent = reinterpret_cast< AnimationNode* >( sal::static_int_cast< sal_IntPtr >(xTunnel->getSomething( getUnoTunnelId() )));
+        mpParent = comphelper::getFromUnoTunnel<AnimationNode>(mxParent.get());
 
         fireChangeListener();
     }