diff options
| author | Mike Kaganski <mike.kaganski@collabora.com> | 2021-06-11 12:07:44 +0200 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2021-06-14 12:46:07 +0200 |
| commit | 49b3b9d3391abb50aefe291d2ee0f8bca7eb6bd0 (patch) | |
| tree | e75e5ade8acbf8aa3f040aa28ef08572752935ad /android/source/src/java/org/libreoffice/ui/FileUtilities.java | |
| parent | bump product version to 7.2.0.0.beta1+ (diff) | |
| download | core-49b3b9d3391abb50aefe291d2ee0f8bca7eb6bd0.tar.gz core-49b3b9d3391abb50aefe291d2ee0f8bca7eb6bd0.zip | |
Assert on valid order of which ids in ranges on SfxItemSet creation
This allows to make sure we actually use sorted which ranges,
and then it's safe to call SfxItemSet::MergeRange when needed.
Also this change relaxes the previous requirement that ranges
must be separated by at least one; this allows to have adjacent
ranges, like in
RES_FRMATR_BEGIN, RES_FRMATR_END-1,
RES_GRFATR_BEGIN, RES_GRFATR_END-1,
where RES_FRMATR_END is equal to RES_GRFATR_BEGIN. Allowing this
makes possible to (1) self-document the ranges, so it's clear
which ranges are included; and (2) be safe in case when these
constants would change, so that the one merged range would not
unexpectedly contain everything inserted between RES_FRMATR_END
and RES_GRFATR_BEGIN.
Change-Id: Iaad0f099b85059b3aa318a347aa7fbd3f6d455c7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116909
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 8aaa28ed43978a9a4a20d62368410a57ec05c23f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117114
Diffstat (limited to 'android/source/src/java/org/libreoffice/ui/FileUtilities.java')
0 files changed, 0 insertions, 0 deletions