diff options
| author | Eike Rathke <erack@redhat.com> | 2023-04-26 21:11:44 +0200 |
|---|---|---|
| committer | Eike Rathke <erack@redhat.com> | 2023-04-27 01:29:45 +0200 |
| commit | 9a555d79b3b00793edf1d51a8a7c76b723cc436d (patch) | |
| tree | b49de2864bcbcce9ec7b6278474b92a2872986b7 | |
| parent | Update git submodules (diff) | |
| download | core-9a555d79b3b00793edf1d51a8a7c76b723cc436d.tar.gz core-9a555d79b3b00793edf1d51a8a7c76b723cc436d.zip | |
Resolves: tdf#151958 Disable binary search on sorted cache for current releases
Temporary measure until the actual cause is fixed.
The by string query of binary search on sorted cache is broken for
mixed types like here the numeric date cells and text cells.
Change-Id: Icfe0b0c30987fcefdd6ed11066ea9113f3b4dabe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151074
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
| -rw-r--r-- | sc/source/core/data/queryiter.cxx | 18 |
1 files changed, 15 insertions, 3 deletions
diff --git a/sc/source/core/data/queryiter.cxx b/sc/source/core/data/queryiter.cxx index 7fef5381750e..58709957157a 100644 --- a/sc/source/core/data/queryiter.cxx +++ b/sc/source/core/data/queryiter.cxx @@ -1231,10 +1231,21 @@ ScQueryCellIteratorAccessSpecific< ScQueryCellIteratorAccess::SortedCache >::Mak return SortedCacheIndexer(rCells, nStartRow, nEndRow, sortedCache); } -static bool CanBeUsedForSorterCache(ScDocument& rDoc, const ScQueryParam& rParam, - SCTAB nTab, const ScFormulaCell* cell, const ScComplexRefData* refData, - ScInterpreterContext& context) +static bool CanBeUsedForSorterCache(ScDocument& /*rDoc*/, const ScQueryParam& /*rParam*/, + SCTAB /*nTab*/, const ScFormulaCell* /*cell*/, const ScComplexRefData* /*refData*/, + ScInterpreterContext& /*context*/) { +#if 1 + /* TODO: tdf#151958 broken by string query of binary search on sorted + * cache, use the direct query instead for releases and fix SortedCache + * implementation after. Not only COUNTIF() is broken, but also COUNTIFS(), + * and maybe lcl_LookupQuery() for VLOOKUP() etc. as well. Just disable + * this for now. + * Can't just return false because below would be unreachable code. Can't + * just #if/#else/#endif either because parameters would be unused. Crap + * this and comment out parameter names. */ + return false; +#else if(!rParam.GetEntry(0).bDoQuery || rParam.GetEntry(1).bDoQuery || rParam.GetEntry(0).GetQueryItems().size() != 1 ) return false; @@ -1290,6 +1301,7 @@ static bool CanBeUsedForSorterCache(ScDocument& rDoc, const ScQueryParam& rParam return false; } return true; +#endif } // Generic query implementation. |