summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Stahl <michael.stahl@allotropia.de>2022-03-11 17:29:41 +0100
committerThorsten Behrens <thorsten.behrens@allotropia.de>2022-03-17 12:24:30 +0100
commiteb84cf3f406808658f3efd9320e0a047c90be12f (patch)
treeb945aeacc6e4f03fe8fda83968541fefbf21f368
parentRelated: tdf#128610 Avoid use-after-free (diff)
downloadcore-eb84cf3f406808658f3efd9320e0a047c90be12f.tar.gz
core-eb84cf3f406808658f3efd9320e0a047c90be12f.zip
hwpfilter: why isn't that path string null terminated
Change-Id: Iaedc23bd91d0d46e34d55dcc65760b73c5772b7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131559 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 4c86ed851bc1c0a2414e254082064760c99437f1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131593 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
-rw-r--r--hwpfilter/source/hwpread.cxx1
1 files changed, 1 insertions, 0 deletions
diff --git a/hwpfilter/source/hwpread.cxx b/hwpfilter/source/hwpread.cxx
index ecb101030f46..6db86575fca8 100644
--- a/hwpfilter/source/hwpread.cxx
+++ b/hwpfilter/source/hwpread.cxx
@@ -454,6 +454,7 @@ bool Picture::Read(HWPFile & hwpf)
scale[1] = tmp16;
hwpf.ReadBlock(picinfo.picun.path, 256); /* Picture File Name: when type is not a Drawing. */
+ picinfo.picun.path[255] = 0; // ensure null terminated
hwpf.ReadBlock(reserved3, 9); /* Brightness / Contrast / Picture Effect, etc. */
UpdateBBox(this);