diff options
| author | Kohei Yoshida <kohei.yoshida@gmail.com> | 2013-01-11 12:51:13 -0500 |
|---|---|---|
| committer | Markus Mohrhard <markus.mohrhard@googlemail.com> | 2013-01-12 06:45:36 +0000 |
| commit | 0490372a127b03dde0397009758289e94862a662 (patch) | |
| tree | 32664e2afe6d18558e49f63aa2d292bbd03ad386 | |
| parent | fdo#59084: Sync dimension members after reloading the group data. (diff) | |
| download | core-0490372a127b03dde0397009758289e94862a662.tar.gz core-0490372a127b03dde0397009758289e94862a662.zip | |
Let's not return here to prevent memory leak.
There are several heap objects that are deleted at the end of the
method. Returning prematurely would leak those objects.
Change-Id: If70cb3c9c02e47229d10b30f1542f7b25534d593
Reviewed-on: https://gerrit.libreoffice.org/1654
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
| -rw-r--r-- | sc/source/ui/docshell/dbdocfun.cxx | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sc/source/ui/docshell/dbdocfun.cxx b/sc/source/ui/docshell/dbdocfun.cxx index 5216c6811786..9fea320c87f6 100644 --- a/sc/source/ui/docshell/dbdocfun.cxx +++ b/sc/source/ui/docshell/dbdocfun.cxx @@ -1330,8 +1330,7 @@ bool ScDBDocFunc::DataPilotUpdate( ScDPObject* pOldObj, const ScDPObject* pNewOb if ( pDestObj ) { pDestObj->ReloadGroupTableData(); - if (!pDestObj->SyncAllDimensionMembers()) - return false; + pDestObj->SyncAllDimensionMembers(); pDestObj->InvalidateData(); // before getting the new output area // make sure the table has a name (not set by dialog) |