diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-10-18 11:48:24 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-10-21 13:06:38 +0200 |
| commit | bbe6bc271ac560991ac41b5beeb7ccc139168f1e (patch) | |
| tree | a99d8cefed65150c14dd7194398db71095edd63b | |
| parent | Don't invoke the linker when generating pch files (diff) | |
| download | core-bbe6bc271ac560991ac41b5beeb7ccc139168f1e.tar.gz core-bbe6bc271ac560991ac41b5beeb7ccc139168f1e.zip | |
loplugin:virtualdead unused param in SfxStatusListener::StateChanged
Change-Id: Ic467490ddd1b0762bfa61878c4026afb53b02743
Reviewed-on: https://gerrit.libreoffice.org/81212
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
| -rw-r--r-- | compilerplugins/clang/virtualdead.unusedparams.results | 3 | ||||
| -rw-r--r-- | include/sfx2/sfxstatuslistener.hxx | 2 | ||||
| -rw-r--r-- | sfx2/source/control/sfxstatuslistener.cxx | 4 | ||||
| -rw-r--r-- | svx/source/tbxctrls/tbcontrl.cxx | 4 |
4 files changed, 5 insertions, 8 deletions
diff --git a/compilerplugins/clang/virtualdead.unusedparams.results b/compilerplugins/clang/virtualdead.unusedparams.results index be64ddb4cdcd..a916322515a8 100644 --- a/compilerplugins/clang/virtualdead.unusedparams.results +++ b/compilerplugins/clang/virtualdead.unusedparams.results @@ -136,9 +136,6 @@ include/oox/export/shapes.hxx:136 include/sfx2/objsh.hxx:637 void SfxObjectShell::FillClass(class SvGlobalName *,enum SotClipboardFormatId *,class rtl::OUString *,class rtl::OUString *,class rtl::OUString *,int,_Bool,)const 1101111 -include/sfx2/sfxstatuslistener.hxx:49 - void SfxStatusListener::StateChanged(unsigned short,enum SfxItemState,const class SfxPoolItem *,) - 011 include/sfx2/stbitem.hxx:100 _Bool SfxStatusBarControl::MouseButtonUp(const class MouseEvent &,) 0 diff --git a/include/sfx2/sfxstatuslistener.hxx b/include/sfx2/sfxstatuslistener.hxx index 56ea2d57b11d..01ffb8518e9c 100644 --- a/include/sfx2/sfxstatuslistener.hxx +++ b/include/sfx2/sfxstatuslistener.hxx @@ -46,7 +46,7 @@ class SFX2_DLLPUBLIC SfxStatusListener : public cppu::WeakImplHelper< void UnBind(); void ReBind(); - virtual void StateChanged( sal_uInt16 nSID, SfxItemState eState, const SfxPoolItem* pState ); + virtual void StateChanged( SfxItemState eState, const SfxPoolItem* pState ); // XComponent virtual void SAL_CALL dispose() override; diff --git a/sfx2/source/control/sfxstatuslistener.cxx b/sfx2/source/control/sfxstatuslistener.cxx index 79263071914d..a16841ba81a8 100644 --- a/sfx2/source/control/sfxstatuslistener.cxx +++ b/sfx2/source/control/sfxstatuslistener.cxx @@ -65,7 +65,7 @@ SfxStatusListener::~SfxStatusListener() } // old sfx controller item C++ API -void SfxStatusListener::StateChanged( sal_uInt16, SfxItemState, const SfxPoolItem* ) +void SfxStatusListener::StateChanged( SfxItemState, const SfxPoolItem* ) { // must be implemented by sub class } @@ -223,7 +223,7 @@ void SAL_CALL SfxStatusListener::statusChanged( const FeatureStateEvent& rEvent) } } - StateChanged( m_nSlotID, eState, pItem.get() ); + StateChanged( eState, pItem.get() ); } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx index 510d695ffba0..b3b6b51db395 100644 --- a/svx/source/tbxctrls/tbcontrl.cxx +++ b/svx/source/tbxctrls/tbcontrl.cxx @@ -653,7 +653,7 @@ class SfxStyleControllerItem_Impl : public SfxStatusListener SvxStyleToolBoxControl& rTbxCtl ); protected: - virtual void StateChanged( sal_uInt16 nSID, SfxItemState eState, const SfxPoolItem* pState ) override; + virtual void StateChanged( SfxItemState eState, const SfxPoolItem* pState ) override; private: SvxStyleToolBoxControl& rControl; @@ -2741,7 +2741,7 @@ SfxStyleControllerItem_Impl::SfxStyleControllerItem_Impl( } void SfxStyleControllerItem_Impl::StateChanged( - sal_uInt16, SfxItemState eState, const SfxPoolItem* pState ) + SfxItemState eState, const SfxPoolItem* pState ) { switch ( GetId() ) { |