summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2019-08-16 09:56:29 +0200
committerSamuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>2022-01-18 09:57:59 +0100
commit95a422aa7105a94f6b0b78246d83df3180a74ecc (patch)
tree06e62d531acdecec4ffbfddb341f14f6e8ad57f8
parentAdd a TaskStopwatch to interrupt idle loops (diff)
downloadcore-95a422aa7105a94f6b0b78246d83df3180a74ecc.tar.gz
core-95a422aa7105a94f6b0b78246d83df3180a74ecc.zip
Drop bogus check from TimerTest::testStopwatch
(that had been added with 6e13585508ca3c9b66c6571ad1eb42bfcb66ef0b "Add a TaskStopwatch to interrupt idle loops"). For each StopwatchIdle, m_nIters counts the calls to Invoke before it calls Stop (which it calls based on tools::Time::GetSystemTicks calculations). But the number of such GetSystemTicks() spent in each Invoke is nondeterministic (it can e.g. be affected by the overall system load), so a2Idle may Stop prior to a1Idle and thus have a lower nIter2 than nIter1. Change-Id: I416eee9774c3605be25e9832b24dec7d9dcb00c2 Reviewed-on: https://gerrit.libreoffice.org/77561 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 92e42a0fde32e3f2dbe2c786a0e41547e4912b4b)
-rw-r--r--vcl/qa/cppunit/timer.cxx1
1 files changed, 0 insertions, 1 deletions
diff --git a/vcl/qa/cppunit/timer.cxx b/vcl/qa/cppunit/timer.cxx
index 0531c0c7f99c..5154c1947a75 100644
--- a/vcl/qa/cppunit/timer.cxx
+++ b/vcl/qa/cppunit/timer.cxx
@@ -603,7 +603,6 @@ void TimerTest::testStopwatch()
bool b1Done = a1Idle.isDone(n1Iter);
bool b2Done = a2Idle.isDone(n2Iter);
- CPPUNIT_ASSERT(n1Iter >= n2Iter);
if (b1Done && b2Done)
break;