diff options
author | Noel Grandin <noel@peralex.com> | 2015-10-14 09:09:22 +0200 |
---|---|---|
committer | Noel Grandin <noel@peralex.com> | 2015-10-14 09:55:11 +0200 |
commit | abd980d4ec16fed637d3fce580e7ae728f69d564 (patch) | |
tree | 698887f8030a4114bdce50d54427c364b609fc11 | |
parent | cid#1326131 'Constant' variable guards dead code (diff) | |
download | core-abd980d4ec16fed637d3fce580e7ae728f69d564.tar.gz core-abd980d4ec16fed637d3fce580e7ae728f69d564.zip |
cid#1326605, cid#1326604 BC: Bad casts of object references
Change-Id: I85fa5fd4671d749850af854a7d4ba934416d892b
-rw-r--r-- | qadevOOo/tests/java/ifc/beans/_XProperty.java | 3 | ||||
-rw-r--r-- | reportbuilder/java/org/libreoffice/report/pentaho/PentahoReportJob.java | 7 |
2 files changed, 3 insertions, 7 deletions
diff --git a/qadevOOo/tests/java/ifc/beans/_XProperty.java b/qadevOOo/tests/java/ifc/beans/_XProperty.java index c81c53f30351..cb3886701621 100644 --- a/qadevOOo/tests/java/ifc/beans/_XProperty.java +++ b/qadevOOo/tests/java/ifc/beans/_XProperty.java @@ -28,8 +28,7 @@ public class _XProperty extends MultiMethodTest { public void _getAsProperty() { Property prop = oObj.getAsProperty(); - boolean res = (prop.Name instanceof String); - res &= (prop.Type != null); + boolean res = (prop.Type != null); tRes.tested("getAsProperty()", res); } }
\ No newline at end of file diff --git a/reportbuilder/java/org/libreoffice/report/pentaho/PentahoReportJob.java b/reportbuilder/java/org/libreoffice/report/pentaho/PentahoReportJob.java index 9e0e429b0b92..6c598556da7d 100644 --- a/reportbuilder/java/org/libreoffice/report/pentaho/PentahoReportJob.java +++ b/reportbuilder/java/org/libreoffice/report/pentaho/PentahoReportJob.java @@ -220,11 +220,8 @@ public class PentahoReportJob implements ReportJob val = reportFunction.getChildValues()[0]; } } - if (val instanceof ContextLookup) - { - final ContextLookup context = (ContextLookup) val; - name = context.getName(); - } + final ContextLookup context = (ContextLookup) val; + name = context.getName(); break; } } |