diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2023-06-02 20:51:53 +0200 |
|---|---|---|
| committer | Caolán McNamara <caolan.mcnamara@collabora.com> | 2023-06-28 17:32:07 +0200 |
| commit | cebc90f3cf0a1dfa6f4f682dc9fff8d2fecfdd28 (patch) | |
| tree | 9171a1d569b5abd3f81ee3145f085bccee7ad623 | |
| parent | ofz#49713 Heap-use-after-free (diff) | |
| download | core-cebc90f3cf0a1dfa6f4f682dc9fff8d2fecfdd28.tar.gz core-cebc90f3cf0a1dfa6f4f682dc9fff8d2fecfdd28.zip | |
remove unnecessary ScPatternAttr copy
slightly speeds up loading document with large number of patterns
Change-Id: I1b82145fb0f8a62da0d5a46a43594f7085ce2c22
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152564
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit c01fa7ff3bcd3447ea190bcc1833beb7c48a8803)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152535
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153585
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
| -rw-r--r-- | sc/source/core/data/table2.cxx | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sc/source/core/data/table2.cxx b/sc/source/core/data/table2.cxx index 3ed331fbc908..ebe63974cbbc 100644 --- a/sc/source/core/data/table2.cxx +++ b/sc/source/core/data/table2.cxx @@ -2915,8 +2915,7 @@ namespace std::vector<ScAttrEntry> aData(rOrigData); for (size_t nIdx = 0; nIdx < aData.size(); ++nIdx) { - ScPatternAttr aNewPattern(*aData[nIdx].pPattern); - aData[nIdx].pPattern = &rDocument.GetPool()->Put(aNewPattern); + aData[nIdx].pPattern = &rDocument.GetPool()->Put(*aData[nIdx].pPattern); } return aData; } |