diff options
author | Caolán McNamara <caolanm@redhat.com> | 2022-03-25 21:26:43 +0000 |
---|---|---|
committer | Andras Timar <andras.timar@collabora.com> | 2022-05-17 15:47:05 +0200 |
commit | 9d825848618a483bbaddc7247c096452003d551d (patch) | |
tree | fdb3b672d3d9526d51f58914f7a4b0bfd1b70bd6 | |
parent | forcepoint#99 SwTextFormatter unaware that FirstOfBorderMerge was deleted (diff) | |
download | core-9d825848618a483bbaddc7247c096452003d551d.tar.gz core-9d825848618a483bbaddc7247c096452003d551d.zip |
forcepoint#91 fix crash on layout of specific html
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132129
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit be04a8072e4af30ca6ead36aa92d5f380cd9feb9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132483
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit 4abce69fca83f5c98bb1fc0678cc1ce9cedd4750)
Change-Id: I145649e18f382c67ea34290f44fa219b7926127f
-rw-r--r-- | sw/qa/extras/layout/data/forcepoint89.html | bin | 0 -> 3321 bytes | |||
-rw-r--r-- | sw/qa/extras/layout/data/forcepoint91.html | bin | 0 -> 49256 bytes | |||
-rw-r--r-- | sw/qa/extras/layout/data/tdf147485-forcepoint.doc | bin | 0 -> 62544 bytes | |||
-rw-r--r-- | sw/qa/extras/layout/layout.cxx | 28 | ||||
-rw-r--r-- | sw/source/core/layout/tabfrm.cxx | 2 |
5 files changed, 30 insertions, 0 deletions
diff --git a/sw/qa/extras/layout/data/forcepoint89.html b/sw/qa/extras/layout/data/forcepoint89.html Binary files differnew file mode 100644 index 000000000000..7998a2b0b979 --- /dev/null +++ b/sw/qa/extras/layout/data/forcepoint89.html diff --git a/sw/qa/extras/layout/data/forcepoint91.html b/sw/qa/extras/layout/data/forcepoint91.html Binary files differnew file mode 100644 index 000000000000..eacbd2e05ab8 --- /dev/null +++ b/sw/qa/extras/layout/data/forcepoint91.html diff --git a/sw/qa/extras/layout/data/tdf147485-forcepoint.doc b/sw/qa/extras/layout/data/tdf147485-forcepoint.doc Binary files differnew file mode 100644 index 000000000000..cb630efb8717 --- /dev/null +++ b/sw/qa/extras/layout/data/tdf147485-forcepoint.doc diff --git a/sw/qa/extras/layout/layout.cxx b/sw/qa/extras/layout/layout.cxx index 15ebaa608fd4..022bc431cb50 100644 --- a/sw/qa/extras/layout/layout.cxx +++ b/sw/qa/extras/layout/layout.cxx @@ -2308,12 +2308,34 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testRedlineTables) CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testUXTSOREL) { createDoc("LIBREOFFICE-UXTSOREL.rtf"); } #endif +//just care it doesn't crash/assert +CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testForcepoint76) +{ + createDoc("forcepoint76-1.rtf"); +} + +//just care it doesn't crash/assert +#if 0 // no createSwWebDoc +CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testForcepoint89) +{ + createSwWebDoc(DATA_DIRECTORY, "forcepoint89.html"); +} +#endif + CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testForcepoint90) { createDoc("forcepoint90.rtf"); } //just care it doesn't crash/assert +#if 0 // no createSwWebDoc +CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testForcepoint91) +{ + createSwWebDoc(DATA_DIRECTORY, "forcepoint91.html"); +} +#endif + +//just care it doesn't crash/assert CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testForcepoint92) { createDoc("forcepoint92.doc"); } //just care it doesn't crash/assert @@ -2332,6 +2354,12 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testForcepoint94) #endif //just care it doesn't crash/assert +CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testTdf147485Forcepoint) +{ + createDoc("tdf147485-forcepoint.doc"); +} + +//just care it doesn't crash/assert #if 0 // no createSwWebDoc CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testForcepoint99) { diff --git a/sw/source/core/layout/tabfrm.cxx b/sw/source/core/layout/tabfrm.cxx index 02118901320d..3d4f08b2ccf9 100644 --- a/sw/source/core/layout/tabfrm.cxx +++ b/sw/source/core/layout/tabfrm.cxx @@ -1603,6 +1603,8 @@ static bool lcl_InnerCalcLayout( SwFrame *pFrame, if ( pFrame->IsLayoutFrame() && ( !_bOnlyRowsAndCells || pFrame->IsRowFrame() || pFrame->IsCellFrame() ) ) { + SwFrameDeleteGuard aDeleteGuard(pFrame); + // #130744# An invalid locked table frame will // not be calculated => It will not become valid => // Loop in lcl_RecalcRow(). Therefore we do not consider them for bRet. |