loplugin:constparams

Change-Id: I7c695073d9a9d3b7a641d6eb9fe01a47d8c3a504
Reviewed-on: https://gerrit.libreoffice.org/48392
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

25 files changed, 42 insertions, 40 deletions

diff --git a/basctl/source/basicide/basobj3.cxx b/basctl/source/basicide/basobj3.cxx
index 246486331538..7043bba6110a 100644
--- a/basctl/source/basicide/basobj3.cxx
+++ b/basctl/source/basicide/basobj3.cxx
@@ -44,7 +44,7 @@ using namespace ::com::sun::star::uno;
 using namespace ::com::sun::star::container;
 
 extern "C" {
-    SAL_DLLPUBLIC_EXPORT long basicide_handle_basic_error( void * pPtr )
+    SAL_DLLPUBLIC_EXPORT long basicide_handle_basic_error( void const * pPtr )
     {
         return HandleBasicError( static_cast<StarBASIC const *>(pPtr) );
     }
diff --git a/compilerplugins/clang/constparams.cxx b/compilerplugins/clang/constparams.cxx
index f075d0c06edc..89be6f684033 100644
--- a/compilerplugins/clang/constparams.cxx
+++ b/compilerplugins/clang/constparams.cxx
@@ -209,6 +209,8 @@ bool ConstParams::CheckTraverseFunctionDecl(FunctionDecl * functionDecl)
             || name == "Read_Footnote"
             || name == "Read_Field"
             || name == "Read_And"
+            // passed as a LINK<> to another method
+            || name == "GlobalBasicErrorHdl_Impl"
             )
             return false;
     }
diff --git a/include/svx/extrud3d.hxx b/include/svx/extrud3d.hxx
index 7001ee86cfd5..1b78d4547740 100644
--- a/include/svx/extrud3d.hxx
+++ b/include/svx/extrud3d.hxx
@@ -44,7 +44,7 @@ private:
 
 public:
 
-    E3dExtrudeObj(E3dDefaultAttributes& rDefault, const basegfx::B2DPolyPolygon& rPP, double fDepth);
+    E3dExtrudeObj(E3dDefaultAttributes const & rDefault, const basegfx::B2DPolyPolygon& rPP, double fDepth);
     E3dExtrudeObj();
 
     // PercentDiagonal: 0..100, before 0.0..0.5
diff --git a/include/svx/lathe3d.hxx b/include/svx/lathe3d.hxx
index acc1e4186ce2..3c5a0e23b015 100644
--- a/include/svx/lathe3d.hxx
+++ b/include/svx/lathe3d.hxx
@@ -42,7 +42,7 @@ class SVX_DLLPUBLIC E3dLatheObj final : public E3dCompoundObject
     void SetDefaultAttributes(E3dDefaultAttributes const & rDefault);
 
 public:
-    E3dLatheObj(E3dDefaultAttributes& rDefault, const basegfx::B2DPolyPolygon& rPoly2D);
+    E3dLatheObj(E3dDefaultAttributes const & rDefault, const basegfx::B2DPolyPolygon& rPoly2D);
     E3dLatheObj();
 
     // HorizontalSegments:
diff --git a/sax/source/fastparser/fastparser.cxx b/sax/source/fastparser/fastparser.cxx
index f48ad47f2937..ff5388f53d5f 100644
--- a/sax/source/fastparser/fastparser.cxx
+++ b/sax/source/fastparser/fastparser.cxx
@@ -251,7 +251,7 @@ private:
     bool consume(EventList&);
     void deleteUsedEvents();
     void sendPendingCharacters();
-    void addUnknownElementWithPrefix(const xmlChar **attributes, int i, rtl::Reference< FastAttributeList >& xAttributes);
+    void addUnknownElementWithPrefix(const xmlChar **attributes, int i, rtl::Reference< FastAttributeList > const & xAttributes);
 
     sal_Int32 GetToken( const xmlChar* pName, sal_Int32 nameLen );
     /// @throws css::xml::sax::SAXException
@@ -1231,7 +1231,7 @@ void FastSaxParserImpl::callbackStartElement(const xmlChar *localName , const xm
     }
 }
 
-void FastSaxParserImpl::addUnknownElementWithPrefix(const xmlChar **attributes, int i, rtl::Reference< FastAttributeList >& xAttributes)
+void FastSaxParserImpl::addUnknownElementWithPrefix(const xmlChar **attributes, int i, rtl::Reference< FastAttributeList > const & xAttributes)
 {
     OUString aNamespaceURI;
     if ( !m_bIgnoreMissingNSDecl || attributes[i + 2] != nullptr )
diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index d8a47d600e19..77ad1046294a 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -1029,9 +1029,9 @@ public:
 
                     //  return TRUE = number format is set
     SC_DLLPUBLIC bool SetString( SCCOL nCol, SCROW nRow, SCTAB nTab, const OUString& rString,
-                                 ScSetStringParam* pParam = nullptr );
+                                 const ScSetStringParam * pParam = nullptr );
     SC_DLLPUBLIC bool SetString( const ScAddress& rPos, const OUString& rString,
-                                 ScSetStringParam* pParam = nullptr );
+                                 const ScSetStringParam* pParam = nullptr );
 
     /**
      * This method manages the lifecycle of the passed edit text object. When
diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx
index ac1b6f406fca..9698b4fbc462 100644
--- a/sc/inc/table.hxx
+++ b/sc/inc/table.hxx
@@ -406,7 +406,7 @@ public:
     bool        IsBlockEmpty( SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW nRow2, bool bIgnoreNotes ) const;
 
     bool        SetString( SCCOL nCol, SCROW nRow, SCTAB nTab, const OUString& rString,
-                           ScSetStringParam* pParam = nullptr );
+                           const ScSetStringParam * pParam = nullptr );
 
     bool SetEditText( SCCOL nCol, SCROW nRow, EditTextObject* pEditText );
     void SetEditText( SCCOL nCol, SCROW nRow, const EditTextObject& rEditText, const SfxItemPool* pEditPool );
@@ -505,7 +505,7 @@ public:
         sc::CopyFromClipContext& rCxt, const ScTable& rClipTab, sc::ColumnSpanSet& rBroadcastSpans );
 
     void CopyOneCellFromClip(
-        sc::CopyFromClipContext& rCxt, SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW nRow2, SCROW nSrcRow, ScTable* pSrcTab );
+        sc::CopyFromClipContext& rCxt, SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW nRow2, SCROW nSrcRow, const ScTable* pSrcTab );
 
     void CopyFromClip(
         sc::CopyFromClipContext& rCxt, SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW nRow2,
@@ -531,7 +531,7 @@ public:
         InsertDeleteFlags nFlags, bool bMarked, ScTable* pDestTab );
 
     void        CopyConditionalFormat( SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW nRow2,
-                            SCCOL nDx, SCROW nDy, ScTable* pTable);
+                            SCCOL nDx, SCROW nDy, const ScTable* pTable);
     void        TransposeClip( SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW nRow2,
                                 ScTable* pTransClip, InsertDeleteFlags nFlags, bool bAsLink );
 
@@ -1077,11 +1077,11 @@ private:
 
     void FillSeriesSimple(
         const ScCellValue& rSrcCell, SCCOLROW& rInner, SCCOLROW nIMin, SCCOLROW nIMax,
-        SCCOLROW& rCol, SCCOLROW& rRow, bool bVertical, ScProgress* pProgress, sal_uLong& rProgress );
+        const SCCOLROW& rCol, const SCCOLROW& rRow, bool bVertical, ScProgress* pProgress, sal_uLong& rProgress );
 
     void FillAutoSimple(
         SCCOLROW nISrcStart, SCCOLROW nISrcEnd, SCCOLROW nIStart, SCCOLROW nIEnd,
-        SCCOLROW& rInner, SCCOLROW& rCol, SCCOLROW& rRow,
+        SCCOLROW& rInner, const SCCOLROW& rCol, const SCCOLROW& rRow,
         sal_uLong nActFormCnt, sal_uLong nMaxFormCnt,
         bool bHasFiltered, bool bVertical, bool bPositive,
         ScProgress* pProgress, sal_uLong& rProgress );
diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx
index ea48500ad16b..f4e2d98bb41c 100644
--- a/sc/source/core/data/document.cxx
+++ b/sc/source/core/data/document.cxx
@@ -3360,7 +3360,7 @@ void ScDocument::FillTabMarked( SCTAB nSrcTab, const ScMarkData& rMark,
 }
 
 bool ScDocument::SetString( SCCOL nCol, SCROW nRow, SCTAB nTab, const OUString& rString,
-                            ScSetStringParam* pParam )
+                            const ScSetStringParam* pParam )
 {
     ScTable* pTab = FetchTable(nTab);
     if (!pTab)
@@ -3399,7 +3399,7 @@ bool ScDocument::SetString( SCCOL nCol, SCROW nRow, SCTAB nTab, const OUString&
 }
 
 bool ScDocument::SetString(
-    const ScAddress& rPos, const OUString& rString, ScSetStringParam* pParam )
+    const ScAddress& rPos, const OUString& rString, const ScSetStringParam* pParam )
 {
     return SetString(rPos.Col(), rPos.Row(), rPos.Tab(), rString, pParam);
 }
diff --git a/sc/source/core/data/table2.cxx b/sc/source/core/data/table2.cxx
index de8eb7a9f5ba..2c5ed4149566 100644
--- a/sc/source/core/data/table2.cxx
+++ b/sc/source/core/data/table2.cxx
@@ -566,7 +566,7 @@ void ScTable::CopyCellToDocument(SCCOL nSrcCol, SCROW nSrcRow, SCCOL nDestCol, S
 }
 
 void ScTable::CopyConditionalFormat( SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW nRow2,
-        SCCOL nDx, SCROW nDy, ScTable* pTable)
+        SCCOL nDx, SCROW nDy, const ScTable* pTable)
 {
     ScRange aOldRange( nCol1 - nDx, nRow1 - nDy, pTable->nTab, nCol2 - nDx, nRow2 - nDy, pTable->nTab);
     ScRange aNewRange( nCol1, nRow1, nTab, nCol2, nRow2, nTab );
@@ -1386,7 +1386,7 @@ bool ScTable::TestCopyScenarioTo( const ScTable* pDestTab ) const
 }
 
 bool ScTable::SetString( SCCOL nCol, SCROW nRow, SCTAB nTabP, const OUString& rString,
-                         ScSetStringParam* pParam )
+                         const ScSetStringParam * pParam )
 {
     if (ValidColRow(nCol,nRow))
         return aCol[nCol].SetString(
diff --git a/sc/source/core/data/table4.cxx b/sc/source/core/data/table4.cxx
index 64ac8f3088b1..805915768a4d 100644
--- a/sc/source/core/data/table4.cxx
+++ b/sc/source/core/data/table4.cxx
@@ -1268,7 +1268,7 @@ void ScTable::FillFormulaVertical(
 
 void ScTable::FillSeriesSimple(
     const ScCellValue& rSrcCell, SCCOLROW& rInner, SCCOLROW nIMin, SCCOLROW nIMax,
-    SCCOLROW& rCol, SCCOLROW& rRow, bool bVertical, ScProgress* pProgress, sal_uLong& rProgress )
+    const SCCOLROW& rCol, const SCCOLROW& rRow, bool bVertical, ScProgress* pProgress, sal_uLong& rProgress )
 {
     bool bHidden = false;
     SCCOLROW nHiddenLast = -1;
@@ -1348,7 +1348,7 @@ void ScTable::FillSeriesSimple(
 
 void ScTable::FillAutoSimple(
     SCCOLROW nISrcStart, SCCOLROW nISrcEnd, SCCOLROW nIStart, SCCOLROW nIEnd,
-    SCCOLROW& rInner, SCCOLROW& rCol, SCCOLROW& rRow, sal_uLong nActFormCnt,
+    SCCOLROW& rInner, const SCCOLROW& rCol, const SCCOLROW& rRow, sal_uLong nActFormCnt,
     sal_uLong nMaxFormCnt, bool bHasFiltered, bool bVertical, bool bPositive,
     ScProgress* pProgress, sal_uLong& rProgress )
 {
diff --git a/sc/source/core/data/table7.cxx b/sc/source/core/data/table7.cxx
index 6fe30a795fa7..1c6e16cf36fb 100644
--- a/sc/source/core/data/table7.cxx
+++ b/sc/source/core/data/table7.cxx
@@ -118,7 +118,7 @@ void ScTable::DeleteBeforeCopyFromClip(
 }
 
 void ScTable::CopyOneCellFromClip(
-    sc::CopyFromClipContext& rCxt, SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW nRow2, SCROW nSrcRow, ScTable* pSrcTab )
+    sc::CopyFromClipContext& rCxt, SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW nRow2, SCROW nSrcRow, const ScTable* pSrcTab )
 {
     ScRange aSrcRange = rCxt.getClipDoc()->GetClipParam().getWholeRange();
     SCCOL nSrcColSize = aSrcRange.aEnd.Col() - aSrcRange.aStart.Col() + 1;
diff --git a/sc/source/ui/inc/reffact.hxx b/sc/source/ui/inc/reffact.hxx
index 9c4dea3defdf..9780f9f6839c 100644
--- a/sc/source/ui/inc/reffact.hxx
+++ b/sc/source/ui/inc/reffact.hxx
@@ -31,7 +31,7 @@
     class Class : public SfxChildWindow                                         \
     {                                                                           \
     public:                                                                     \
-        Class( vcl::Window*, sal_uInt16, SfxBindings*, SfxChildWinInfo* );           \
+        Class( vcl::Window*, sal_uInt16, SfxBindings*, const SfxChildWinInfo* ); \
         SFX_DECL_CHILDWINDOW_WITHID(Class);                                     \
     };
 
diff --git a/sc/source/ui/view/reffact.cxx b/sc/source/ui/view/reffact.cxx
index c4c0d419f9c4..2213e91a8df7 100644
--- a/sc/source/ui/view/reffact.cxx
+++ b/sc/source/ui/view/reffact.cxx
@@ -78,7 +78,7 @@ namespace
     Class::Class( vcl::Window*               pParentP,                   \
                     sal_uInt16              nId,                        \
                     SfxBindings*        p,                          \
-                    SfxChildWinInfo*  pInfo )                     \
+                    const SfxChildWinInfo*  pInfo )                     \
         : SfxChildWindow(pParentP, nId)                             \
     {                                                               \
         /************************************************************************************/\
diff --git a/sdext/source/pdfimport/pdfparse/pdfentries.cxx b/sdext/source/pdfimport/pdfparse/pdfentries.cxx
index d9828d355afa..a55c45e7a093 100644
--- a/sdext/source/pdfimport/pdfparse/pdfentries.cxx
+++ b/sdext/source/pdfimport/pdfparse/pdfentries.cxx
@@ -1107,7 +1107,7 @@ static void pad_or_truncate_to_32( const OString& rStr, sal_Char* pBuffer )
 }
 
 // pass at least pData->m_nKeyLength bytes in
-static sal_uInt32 password_to_key( const OString& rPwd, sal_uInt8* pOutKey, PDFFileImplData* pData, bool bComputeO )
+static sal_uInt32 password_to_key( const OString& rPwd, sal_uInt8* pOutKey, PDFFileImplData const * pData, bool bComputeO )
 {
     // see PDF reference 1.4 Algorithm 3.2
     // encrypt pad string
diff --git a/sfx2/source/appl/app.cxx b/sfx2/source/appl/app.cxx
index 82e1d6394f7b..b572ff23cb61 100644
--- a/sfx2/source/appl/app.cxx
+++ b/sfx2/source/appl/app.cxx
@@ -417,7 +417,7 @@ void SfxApplication::Invalidate( sal_uInt16 nId )
 
 #ifndef DISABLE_DYNLOADING
 
-typedef long (*basicide_handle_basic_error)(void*);
+typedef long (*basicide_handle_basic_error)(void const *);
 typedef void (*basicide_macro_organizer)(sal_Int16);
 
 extern "C" { static void thisModule() {} }
diff --git a/sfx2/source/appl/sfxhelp.cxx b/sfx2/source/appl/sfxhelp.cxx
index 971e6f6e263d..acbf7e427bd7 100644
--- a/sfx2/source/appl/sfxhelp.cxx
+++ b/sfx2/source/appl/sfxhelp.cxx
@@ -130,7 +130,7 @@ OUString getHelpRootURL()
     return s_instURL;
 }
 
-bool impl_checkHelpLocalePath(OUString& rpPath)
+bool impl_checkHelpLocalePath(OUString const & rpPath)
 {
     osl::DirectoryItem directoryItem;
     bool bOK = false;
diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index bfc4476fdcd0..0e50ed9141ac 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -3401,7 +3401,7 @@ bool SfxMedium::SetWritableForUserOnly( const OUString& aURL )
 namespace
 {
 /// Get the parent directory of a temporary file for output purposes.
-OUString GetLogicBase(std::unique_ptr<SfxMedium_Impl>& pImpl)
+OUString GetLogicBase(std::unique_ptr<SfxMedium_Impl> const & pImpl)
 {
     OUString aLogicBase;
 
diff --git a/svl/source/items/stylepool.cxx b/svl/source/items/stylepool.cxx
index 6e52248eb82a..15fb042ef0e9 100644
--- a/svl/source/items/stylepool.cxx
+++ b/svl/source/items/stylepool.cxx
@@ -69,7 +69,7 @@ namespace {
         // #i86923#
         Node* findChildNode( const SfxPoolItem& rItem,
                              const bool bIsItemIgnorable );
-        Node* nextItemSet( Node* pLast,
+        Node* nextItemSet( Node const * pLast,
                            const bool bSkipUnusedItemSet,
                            const bool bSkipIgnorable );
         // #i86923#
@@ -155,7 +155,7 @@ namespace {
      * introduce parameters <bSkipUnusedItemSets> and <bSkipIgnorable>
      * and its handling.
      */
-    Node* Node::nextItemSet( Node* pLast,
+    Node* Node::nextItemSet( Node const * pLast,
                              const bool bSkipUnusedItemSets,
                              const bool bSkipIgnorable )
     {
diff --git a/svx/source/engine3d/extrud3d.cxx b/svx/source/engine3d/extrud3d.cxx
index 8a4e829454fb..3b3bb93956c3 100644
--- a/svx/source/engine3d/extrud3d.cxx
+++ b/svx/source/engine3d/extrud3d.cxx
@@ -55,7 +55,7 @@ sdr::properties::BaseProperties* E3dExtrudeObj::CreateObjectSpecificProperties()
 // Constructor creates a two cover surface tools::PolyPolygon and (point-count 1) side
 // surfaces rectangles from the passed PolyPolygon
 
-E3dExtrudeObj::E3dExtrudeObj(E3dDefaultAttributes& rDefault, const basegfx::B2DPolyPolygon& rPP, double fDepth)
+E3dExtrudeObj::E3dExtrudeObj(E3dDefaultAttributes const & rDefault, const basegfx::B2DPolyPolygon& rPP, double fDepth)
 :   E3dCompoundObject(),
     maExtrudePolygon(rPP)
 {
diff --git a/svx/source/engine3d/lathe3d.cxx b/svx/source/engine3d/lathe3d.cxx
index c2fb0f5ac1b1..99268c6d5ff8 100644
--- a/svx/source/engine3d/lathe3d.cxx
+++ b/svx/source/engine3d/lathe3d.cxx
@@ -52,7 +52,7 @@ sdr::properties::BaseProperties* E3dLatheObj::CreateObjectSpecificProperties()
 
 // Constructor from 3D polygon, scale is the conversion factor for the coordinates
 
-E3dLatheObj::E3dLatheObj(E3dDefaultAttributes& rDefault, const basegfx::B2DPolyPolygon& rPoly2D)
+E3dLatheObj::E3dLatheObj(E3dDefaultAttributes const & rDefault, const basegfx::B2DPolyPolygon& rPoly2D)
 :   E3dCompoundObject(),
     maPolyPoly2D(rPoly2D)
 {
diff --git a/svx/source/svdraw/svdopath.cxx b/svx/source/svdraw/svdopath.cxx
index a53539ff0c35..8a14da00bfdd 100644
--- a/svx/source/svdraw/svdopath.cxx
+++ b/svx/source/svdraw/svdopath.cxx
@@ -519,7 +519,7 @@ public:
     bool BegCreate(SdrDragStat& rStat);
     bool MovCreate(SdrDragStat& rStat);
     bool EndCreate(SdrDragStat& rStat, SdrCreateCmd eCmd);
-    bool BckCreate(SdrDragStat& rStat);
+    bool BckCreate(SdrDragStat const & rStat);
     void BrkCreate(SdrDragStat& rStat);
     Pointer GetCreatePointer() const;
 
@@ -1504,7 +1504,7 @@ bool ImpPathForDragAndCreate::EndCreate(SdrDragStat& rStat, SdrCreateCmd eCmd)
     return bRet;
 }
 
-bool ImpPathForDragAndCreate::BckCreate(SdrDragStat& rStat)
+bool ImpPathForDragAndCreate::BckCreate(SdrDragStat const & rStat)
 {
     ImpPathCreateUser* pU=static_cast<ImpPathCreateUser*>(rStat.GetUser());
     if (aPathPolygon.Count()>0) {
diff --git a/sw/source/filter/html/swhtml.cxx b/sw/source/filter/html/swhtml.cxx
index 4d939b4cba8d..4115bb6f9e6b 100644
--- a/sw/source/filter/html/swhtml.cxx
+++ b/sw/source/filter/html/swhtml.cxx
@@ -3224,7 +3224,7 @@ void SwHTMLParser::DeleteAttr( HTMLAttr* pAttr )
         *ppHead = pNext;
 }
 
-void SwHTMLParser::SaveAttrTab(std::shared_ptr<HTMLAttrTable>& rNewAttrTab)
+void SwHTMLParser::SaveAttrTab(std::shared_ptr<HTMLAttrTable> const & rNewAttrTab)
 {
     // preliminary paragraph attributes are not allowed here, they could
     // be set here and then the pointers become invalid!
@@ -3251,7 +3251,7 @@ void SwHTMLParser::SaveAttrTab(std::shared_ptr<HTMLAttrTable>& rNewAttrTab)
     }
 }
 
-void SwHTMLParser::SplitAttrTab( std::shared_ptr<HTMLAttrTable>& rNewAttrTab,
+void SwHTMLParser::SplitAttrTab( std::shared_ptr<HTMLAttrTable> const & rNewAttrTab,
                                  bool bMoveEndBack )
 {
     // preliminary paragraph attributes are not allowed here, they could
@@ -3352,7 +3352,7 @@ void SwHTMLParser::SplitAttrTab( std::shared_ptr<HTMLAttrTable>& rNewAttrTab,
     }
 }
 
-void SwHTMLParser::RestoreAttrTab(std::shared_ptr<HTMLAttrTable>& rNewAttrTab)
+void SwHTMLParser::RestoreAttrTab(std::shared_ptr<HTMLAttrTable> const & rNewAttrTab)
 {
     // preliminary paragraph attributes are not allowed here, they could
     // be set here and then the pointers become invalid!
diff --git a/sw/source/filter/html/swhtml.hxx b/sw/source/filter/html/swhtml.hxx
index 9674a8892eaf..e61ff697bc41 100644
--- a/sw/source/filter/html/swhtml.hxx
+++ b/sw/source/filter/html/swhtml.hxx
@@ -535,10 +535,10 @@ class SwHTMLParser : public SfxHTMLParser, public SwClient
     void DeleteAttr( HTMLAttr* pAttr );
 
     void EndContextAttrs( HTMLAttrContext *pContext );
-    void SaveAttrTab(std::shared_ptr<HTMLAttrTable>& rNewAttrTab);
+    void SaveAttrTab(std::shared_ptr<HTMLAttrTable> const & rNewAttrTab);
     void SplitAttrTab( const SwPosition& rNewPos );
-    void SplitAttrTab(std::shared_ptr<HTMLAttrTable>& rNewAttrTab, bool bMoveEndBack);
-    void RestoreAttrTab(std::shared_ptr<HTMLAttrTable>& rNewAttrTab);
+    void SplitAttrTab(std::shared_ptr<HTMLAttrTable> const & rNewAttrTab, bool bMoveEndBack);
+    void RestoreAttrTab(std::shared_ptr<HTMLAttrTable> const & rNewAttrTab);
     void InsertAttr( const SfxPoolItem& rItem, bool bInsAtStart );
     void InsertAttrs( HTMLAttrs& rAttrs );
 
diff --git a/unotools/source/config/useroptions.cxx b/unotools/source/config/useroptions.cxx
index adf58180204a..fbc7aaf37f6f 100644
--- a/unotools/source/config/useroptions.cxx
+++ b/unotools/source/config/useroptions.cxx
@@ -98,7 +98,7 @@ public:
     OUString GetToken (UserOptToken nToken) const;
     void     SetToken (UserOptToken nToken, OUString const& rNewToken);
     bool     GetBoolValue (UserOptToken nToken) const;
-    void     SetBoolValue (UserOptToken nToken, bool& bNewValue);
+    void     SetBoolValue (UserOptToken nToken, bool bNewValue);
     void     Notify ();
 
 private:
@@ -207,7 +207,7 @@ bool SvtUserOptions::Impl::GetBoolValue (UserOptToken nToken) const
     return GetValue_Impl<bool>( nToken );
 }
 
-void SvtUserOptions::Impl::SetBoolValue (UserOptToken nToken, bool& bNewValue)
+void SvtUserOptions::Impl::SetBoolValue (UserOptToken nToken, bool bNewValue)
 {
     SetValue_Impl<bool>( nToken, bNewValue );
 }
diff --git a/writerfilter/source/ooxml/OOXMLDocumentImpl.cxx b/writerfilter/source/ooxml/OOXMLDocumentImpl.cxx
index c23aa86b464a..f22086e3d224 100644
--- a/writerfilter/source/ooxml/OOXMLDocumentImpl.cxx
+++ b/writerfilter/source/ooxml/OOXMLDocumentImpl.cxx
@@ -421,7 +421,7 @@ namespace {
 // Ensures that the indicator is reset after exiting OOXMLDocumentImpl::resolve
 class StatusIndicatorGuard{
 public:
-    explicit StatusIndicatorGuard(css::uno::Reference<css::task::XStatusIndicator>& xStatusIndicator)
+    explicit StatusIndicatorGuard(css::uno::Reference<css::task::XStatusIndicator> const & xStatusIndicator)
         :mxStatusIndicator(xStatusIndicator)
     {
     }