diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2019-10-01 10:40:07 +0200 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2019-10-01 18:56:06 +0200 |
commit | a2ab2b31b8b8f1fd17d7d6c8f68e5adc1e8d381d (patch) | |
tree | 1ec162e400ea3922d5cf27b93b6a9f26bd923366 | |
parent | Implement parallel version of super-scalar-sample-sort... (diff) | |
download | core-a2ab2b31b8b8f1fd17d7d6c8f68e5adc1e8d381d.tar.gz core-a2ab2b31b8b8f1fd17d7d6c8f68e5adc1e8d381d.zip |
loplugin:referencecasting (clang-cl)
Change-Id: Ie534212b09b92a02b377d0bb348e11c96bf61786
Reviewed-on: https://gerrit.libreoffice.org/79934
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
5 files changed, 16 insertions, 23 deletions
diff --git a/embedserv/source/embed/docholder.cxx b/embedserv/source/embed/docholder.cxx index b1164869f91b..1f1f619cd302 100644 --- a/embedserv/source/embed/docholder.cxx +++ b/embedserv/source/embed/docholder.cxx @@ -679,11 +679,8 @@ void DocumentHolder::CloseFrame() } catch( const uno::Exception& ) { } - else { - uno::Reference<lang::XComponent> xComp(m_xFrame, uno::UNO_QUERY); - if (xComp.is()) - xComp->dispose(); - } + else if (m_xFrame.is()) + m_xFrame->dispose(); m_xFrame.clear(); } @@ -758,13 +755,10 @@ uno::Reference< frame::XFrame2 > DocumentHolder::DocumentFrame() { uno::Reference<frame::XDesktop2> xDesktop = frame::Desktop::create(comphelper::getComponentContext(m_xFactory)); - uno::Reference<frame::XFrame> xFrame(xDesktop,uno::UNO_QUERY); - // the frame will be registered on desktop here, later when the document // is loaded into the frame in ::show() method the terminate listener will be removed // this is so only for outplace activation - if( xFrame.is() ) - m_xFrame.set( xFrame->findFrame( "_blank", 0 ), uno::UNO_QUERY ); + m_xFrame.set( xDesktop->findFrame( "_blank", 0 ), uno::UNO_QUERY ); uno::Reference< util::XCloseBroadcaster > xBroadcaster( m_xFrame, uno::UNO_QUERY ); @@ -871,8 +865,7 @@ void DocumentHolder::resizeWin( const SIZEL& rNewSize ) if ( m_xFrame.is() && aDocLock.GetEmbedDocument() ) { - uno::Reference< awt::XWindow > xWindow( - m_xFrame->getContainerWindow(), uno::UNO_QUERY ); + uno::Reference< awt::XWindow > xWindow = m_xFrame->getContainerWindow(); uno::Reference< awt::XView > xView( xWindow, uno::UNO_QUERY ); if ( xWindow.is() && xView.is() ) diff --git a/winaccessibility/source/service/AccContainerEventListener.cxx b/winaccessibility/source/service/AccContainerEventListener.cxx index 8ae4653beb88..36f5e12b80fa 100644 --- a/winaccessibility/source/service/AccContainerEventListener.cxx +++ b/winaccessibility/source/service/AccContainerEventListener.cxx @@ -369,13 +369,13 @@ void AccContainerEventListener::FireStateFocusedChange(bool enable) //for editable combobox, send focus event on only edit control, bool bSendFocusOnCombobox = true; //send focused event to the first text child - Reference<XAccessibleContext> mxContext(m_xAccessible.get()->getAccessibleContext(), UNO_QUERY); + Reference<XAccessibleContext> mxContext = m_xAccessible.get()->getAccessibleContext(); if(mxContext.is()) { Reference<XAccessible> mxChild = mxContext->getAccessibleChild(0); if(mxChild.is()) { - Reference<XAccessibleContext> mxChildContext(mxChild->getAccessibleContext(),UNO_QUERY); + Reference<XAccessibleContext> mxChildContext = mxChild->getAccessibleContext(); short childrole = mxChildContext->getAccessibleRole(); if (childrole == AccessibleRole::TEXT) { @@ -483,7 +483,7 @@ void AccContainerEventListener::HandleSelectionChangedWithinEvent(const Any& /*o void AccContainerEventListener::UpdateAllChildrenState(XAccessible* pXAccessible) { - Reference<css::accessibility::XAccessibleContext> xContext(pXAccessible->getAccessibleContext(),UNO_QUERY); + Reference<css::accessibility::XAccessibleContext> xContext = pXAccessible->getAccessibleContext(); if(!xContext.is()) { return; @@ -539,7 +539,7 @@ void AccContainerEventListener::HandleNameChangedEvent( Any name ) Reference<XAccessible> mxChild = mxContext->getAccessibleChild(0); if(mxChild.is()) { - Reference<XAccessibleContext> mxChildContext(mxChild->getAccessibleContext(),UNO_QUERY); + Reference<XAccessibleContext> mxChildContext = mxChild->getAccessibleContext(); short childrole = mxChildContext->getAccessibleRole(); if (childrole == AccessibleRole::TEXT) { diff --git a/winaccessibility/source/service/AccObject.cxx b/winaccessibility/source/service/AccObject.cxx index c909b5919836..bf71d8617596 100644 --- a/winaccessibility/source/service/AccObject.cxx +++ b/winaccessibility/source/service/AccObject.cxx @@ -336,7 +336,7 @@ void AccObject::UpdateValue() return ; } - Reference< XAccessibleValue > pRValue(m_xAccContextRef.get(),UNO_QUERY); + Reference< XAccessibleValue > pRValue(m_xAccContextRef,UNO_QUERY); Any pAny; if( pRValue.is() ) { diff --git a/winaccessibility/source/service/AccObjectWinManager.cxx b/winaccessibility/source/service/AccObjectWinManager.cxx index 5ce418f4b68a..b56db56d4bab 100644 --- a/winaccessibility/source/service/AccObjectWinManager.cxx +++ b/winaccessibility/source/service/AccObjectWinManager.cxx @@ -763,7 +763,7 @@ void AccObjectWinManager::SaveTopWindowHandle(HWND hWnd, css::accessibility::XAc AccObjectWinManager::CreateAccEventListener(XAccessible* pXAcc) { ::rtl::Reference<AccEventListener> pRet; - Reference<XAccessibleContext> xContext(pXAcc->getAccessibleContext(),UNO_QUERY); + Reference<XAccessibleContext> xContext = pXAcc->getAccessibleContext(); if(xContext.is()) { switch( xContext->getAccessibleRole() ) @@ -1020,7 +1020,7 @@ bool AccObjectWinManager::IsContainer(XAccessible* pAccessible) { if(pAccessible) { - Reference<XAccessibleContext> xContext(pAccessible->getAccessibleContext(),UNO_QUERY); + Reference<XAccessibleContext> xContext = pAccessible->getAccessibleContext(); if(xContext.is()) { switch( xContext->getAccessibleRole() ) @@ -1090,7 +1090,7 @@ bool AccObjectWinManager::IsStateManageDescendant(XAccessible* pAccessible) { if(pAccessible) { - Reference<XAccessibleContext> xContext(pAccessible->getAccessibleContext(),UNO_QUERY); + Reference<XAccessibleContext> xContext = pAccessible->getAccessibleContext(); if(xContext.is()) { Reference< XAccessibleStateSet > pRState = xContext->getAccessibleStateSet(); @@ -1204,7 +1204,7 @@ bool AccObjectWinManager::IsSpecialToolboItem(css::accessibility::XAccessible* p short AccObjectWinManager::GetRole(css::accessibility::XAccessible* pXAcc) { assert(pXAcc != nullptr); - Reference<css::accessibility::XAccessibleContext> xContext(pXAcc->getAccessibleContext(),UNO_QUERY); + Reference<css::accessibility::XAccessibleContext> xContext = pXAcc->getAccessibleContext(); if(xContext.is()) { return xContext->getAccessibleRole(); diff --git a/winaccessibility/source/service/AccTopWindowListener.cxx b/winaccessibility/source/service/AccTopWindowListener.cxx index e697fe368c08..9a3071086324 100644 --- a/winaccessibility/source/service/AccTopWindowListener.cxx +++ b/winaccessibility/source/service/AccTopWindowListener.cxx @@ -65,7 +65,7 @@ void AccTopWindowListener::HandleWindowOpened( css::accessibility::XAccessible* { systemdata = nullptr; } - Reference<css::accessibility::XAccessibleContext> xContext(pAccessible->getAccessibleContext(),UNO_QUERY); + Reference<css::accessibility::XAccessibleContext> xContext = pAccessible->getAccessibleContext(); if(!xContext.is()) return; @@ -136,7 +136,7 @@ void AccTopWindowListener::windowOpened( const css::lang::EventObject& e ) */ void AccTopWindowListener::AddAllListeners(css::accessibility::XAccessible* pAccessible, css::accessibility::XAccessible* pParentXAcc, HWND pWND) { - Reference<css::accessibility::XAccessibleContext> xContext(pAccessible->getAccessibleContext(),UNO_QUERY); + Reference<css::accessibility::XAccessibleContext> xContext = pAccessible->getAccessibleContext(); if(!xContext.is()) { return; @@ -209,7 +209,7 @@ void AccTopWindowListener::windowClosed( const css::lang::EventObject& e ) if ( pAccessible == nullptr) return; - Reference<css::accessibility::XAccessibleContext> xContext(pAccessible->getAccessibleContext(),UNO_QUERY); + Reference<css::accessibility::XAccessibleContext> xContext = pAccessible->getAccessibleContext(); if(!xContext.is()) { return; |