diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2016-05-10 18:11:27 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2016-05-10 18:11:27 +0200 |
| commit | 498d3d9c4b1b1201f1a8eaeb52cfd0dd9eaa047b (patch) | |
| tree | 808b4e9b39af6d0a4ebd3ef60e0aee9e174db474 | |
| parent | Presumably missing break in switch (diff) | |
| download | core-498d3d9c4b1b1201f1a8eaeb52cfd0dd9eaa047b.tar.gz core-498d3d9c4b1b1201f1a8eaeb52cfd0dd9eaa047b.zip | |
Presumably missing break in switch
The code was like this ever since fd069bee7e57ad529c3c0974559fd2d84ec3151a
"initial import", but it looks more like the break was always missing than that
it was an intended fallthrough. Note how the symmetric FIRSTRIGHT case does end
in a break. Also note that in the original code, the fallthrough case RIGHT
guarded its modifications with
if (bTbx || n <= nPos)
aInnerRect.Right() -= pCli->aSize.Width();
break;
(where the surrounding if got since removed), so it was presumably less likely
that an erroneous fallthrough actually caused any modifications.
Change-Id: Idf7ee117f1e22dee19343684a2f56fbf464bdb7f
| -rw-r--r-- | sfx2/source/appl/workwin.cxx | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sfx2/source/appl/workwin.cxx b/sfx2/source/appl/workwin.cxx index 891ddb94e03e..462b8a55ed4f 100644 --- a/sfx2/source/appl/workwin.cxx +++ b/sfx2/source/appl/workwin.cxx @@ -1708,6 +1708,7 @@ void SfxWorkWindow::ConfigChild_Impl(SfxChildIdentifier eChild, // Is only counted if it is the current window if (i == nPos) aInnerRect.Left() += pCli->aSize.Width(); + break; case SfxChildAlignment::RIGHT: // Toolboxes come always last |