loplugin:unusedmethods

Change-Id: Icd7a0f9909f36363b307b4fe7ee920183881afbb
Reviewed-on: https://gerrit.libreoffice.org/61576
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

17 files changed, 87 insertions, 382 deletions

diff --git a/chart2/source/controller/dialogs/res_LegendPosition.cxx b/chart2/source/controller/dialogs/res_LegendPosition.cxx
index 0d6963266ec9..85750e4b6e71 100644
--- a/chart2/source/controller/dialogs/res_LegendPosition.cxx
+++ b/chart2/source/controller/dialogs/res_LegendPosition.cxx
@@ -240,17 +240,6 @@ void LegendPositionResources::SetChangeHdl( const Link<LinkParamNone*,void>& rLi
     m_aChangeLink = rLink;
 }
 
-SchLegendPositionResources::SchLegendPositionResources(weld::Builder& rBuilder)
-    : m_xCC() // unused in this scenario
-    , m_xCbxShow() // unused in this scenario, assumed to be visible
-    , m_xRbtLeft(rBuilder.weld_radio_button("left"))
-    , m_xRbtRight(rBuilder.weld_radio_button("right"))
-    , m_xRbtTop(rBuilder.weld_radio_button("top"))
-    , m_xRbtBottom(rBuilder.weld_radio_button("bottom"))
-{
-    impl_setRadioButtonToggleHdl();
-}
-
 SchLegendPositionResources::SchLegendPositionResources(weld::Builder& rBuilder,
     const uno::Reference< uno::XComponentContext >& xCC)
     : m_xCC(xCC)
@@ -378,54 +367,6 @@ IMPL_LINK_NOARG(SchLegendPositionResources, PositionEnableHdl, weld::ToggleButto
     m_aChangeLink.Call(nullptr);
 }
 
-void SchLegendPositionResources::initFromItemSet( const SfxItemSet& rInAttrs )
-{
-    const SfxPoolItem* pPoolItem = nullptr;
-    if( rInAttrs.GetItemState( SCHATTR_LEGEND_POS, true, &pPoolItem ) == SfxItemState::SET )
-    {
-        chart2::LegendPosition nLegendPosition = static_cast<chart2::LegendPosition>(static_cast<const SfxInt32Item*>(pPoolItem)->GetValue());
-        switch( nLegendPosition )
-        {
-            case chart2::LegendPosition_LINE_START:
-                m_xRbtLeft->set_active(true);
-                break;
-            case chart2::LegendPosition_PAGE_START:
-                m_xRbtTop->set_active(true);
-                break;
-            case chart2::LegendPosition_LINE_END:
-                m_xRbtRight->set_active(true);
-                break;
-            case chart2::LegendPosition_PAGE_END:
-                m_xRbtBottom->set_active(true);
-                break;
-            default:
-                break;
-        }
-    }
-
-    if (m_xCbxShow && rInAttrs.GetItemState( SCHATTR_LEGEND_SHOW, true, &pPoolItem ) == SfxItemState::SET)
-    {
-        bool bShow = static_cast< const SfxBoolItem * >( pPoolItem )->GetValue();
-        m_xCbxShow->set_active(bShow);
-    }
-}
-
-void SchLegendPositionResources::writeToItemSet( SfxItemSet& rOutAttrs ) const
-{
-    chart2::LegendPosition nLegendPosition = chart2::LegendPosition_CUSTOM;
-    if( m_xRbtLeft->get_active() )
-        nLegendPosition = chart2::LegendPosition_LINE_START;
-    else if( m_xRbtTop->get_active() )
-        nLegendPosition = chart2::LegendPosition_PAGE_START;
-    else if( m_xRbtRight->get_active() )
-        nLegendPosition = chart2::LegendPosition_LINE_END;
-    else if( m_xRbtBottom->get_active() )
-        nLegendPosition = chart2::LegendPosition_PAGE_END;
-    rOutAttrs.Put( SfxInt32Item(SCHATTR_LEGEND_POS, static_cast<sal_Int32>(nLegendPosition) ) );
-
-    rOutAttrs.Put( SfxBoolItem(SCHATTR_LEGEND_SHOW, !m_xCbxShow || m_xCbxShow->get_active()) );
-}
-
 IMPL_LINK(SchLegendPositionResources, PositionChangeHdl, weld::ToggleButton&, rRadio, void )
 {
     //for each radio click there are coming two change events
@@ -435,11 +376,6 @@ IMPL_LINK(SchLegendPositionResources, PositionChangeHdl, weld::ToggleButton&, rR
         m_aChangeLink.Call(nullptr);
 }
 
-void SchLegendPositionResources::SetChangeHdl( const Link<LinkParamNone*,void>& rLink )
-{
-    m_aChangeLink = rLink;
-}
-
 } //namespace chart
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/chart2/source/controller/dialogs/res_Titles.cxx b/chart2/source/controller/dialogs/res_Titles.cxx
index 7feec41cc2d8..90d35f0da020 100644
--- a/chart2/source/controller/dialogs/res_Titles.cxx
+++ b/chart2/source/controller/dialogs/res_Titles.cxx
@@ -174,28 +174,6 @@ SchTitleResources::~SchTitleResources()
 {
 }
 
-bool SchTitleResources::IsModified()
-{
-    return m_xEd_Main->get_value_changed_from_saved()
-        || m_xEd_Sub->get_value_changed_from_saved()
-        || m_xEd_XAxis->get_value_changed_from_saved()
-        || m_xEd_YAxis->get_value_changed_from_saved()
-        || m_xEd_ZAxis->get_value_changed_from_saved()
-        || m_xEd_SecondaryXAxis->get_value_changed_from_saved()
-        || m_xEd_SecondaryYAxis->get_value_changed_from_saved();
-}
-
-void SchTitleResources::ClearModifyFlag()
-{
-    m_xEd_Main->save_value();
-    m_xEd_Sub->save_value();
-    m_xEd_XAxis->save_value();
-    m_xEd_YAxis->save_value();
-    m_xEd_ZAxis->save_value();
-    m_xEd_SecondaryXAxis->save_value();
-    m_xEd_SecondaryYAxis->save_value();
-}
-
 void SchTitleResources::writeToResources( const TitleDialogData& rInput )
 {
     m_xFT_Main->set_sensitive( rInput.aPossibilityList[0] );
diff --git a/chart2/source/controller/inc/res_LegendPosition.hxx b/chart2/source/controller/inc/res_LegendPosition.hxx
index 1568781e4818..9dc6f6fef230 100644
--- a/chart2/source/controller/inc/res_LegendPosition.hxx
+++ b/chart2/source/controller/inc/res_LegendPosition.hxx
@@ -74,8 +74,6 @@ class SchLegendPositionResources final
 {
 
 public:
-    //constructor without Display checkbox
-    SchLegendPositionResources(weld::Builder& rBuilder);
     //constructor inclusive Display checkbox
     SchLegendPositionResources(weld::Builder& rBuilder, const css::uno::Reference<
                        css::uno::XComponentContext>& xCC );
@@ -84,11 +82,6 @@ public:
     void writeToResources( const css::uno::Reference< css::frame::XModel >& xChartModel );
     void writeToModel( const css::uno::Reference< css::frame::XModel >& xChartModel ) const;
 
-    void initFromItemSet( const SfxItemSet& rInAttrs );
-    void writeToItemSet( SfxItemSet& rOutAttrs ) const;
-
-    void SetChangeHdl( const Link<LinkParamNone*,void>& rLink );
-
     DECL_LINK(PositionEnableHdl, weld::ToggleButton&, void);
     DECL_LINK(PositionChangeHdl, weld::ToggleButton&, void);
 
diff --git a/chart2/source/controller/inc/res_Titles.hxx b/chart2/source/controller/inc/res_Titles.hxx
index 8ba85b7ddb9a..9541a2c82ba9 100644
--- a/chart2/source/controller/inc/res_Titles.hxx
+++ b/chart2/source/controller/inc/res_Titles.hxx
@@ -70,9 +70,6 @@ public:
     void writeToResources( const TitleDialogData& rInput );
     void readFromResources( TitleDialogData& rOutput );
 
-    bool IsModified();
-    void ClearModifyFlag();
-
 private:
     std::unique_ptr<weld::Label> m_xFT_Main;
     std::unique_ptr<weld::Label> m_xFT_Sub;
diff --git a/compilerplugins/clang/unusedmethods.results b/compilerplugins/clang/unusedmethods.results
index 73113d99a074..ffd44427b781 100644
--- a/compilerplugins/clang/unusedmethods.results
+++ b/compilerplugins/clang/unusedmethods.results
@@ -8,6 +8,18 @@ basic/source/inc/buffer.hxx:46
     void SbiBuffer::operator+=(int)
 canvas/source/vcl/impltools.hxx:105
      vclcanvas::tools::LocalGuard::LocalGuard()
+chart2/source/controller/inc/res_LegendPosition.hxx:78
+     chart::SchLegendPositionResources::SchLegendPositionResources(class weld::Builder &)
+chart2/source/controller/inc/res_LegendPosition.hxx:87
+    void chart::SchLegendPositionResources::initFromItemSet(const class SfxItemSet &)
+chart2/source/controller/inc/res_LegendPosition.hxx:88
+    void chart::SchLegendPositionResources::writeToItemSet(class SfxItemSet &) const
+chart2/source/controller/inc/res_LegendPosition.hxx:90
+    void chart::SchLegendPositionResources::SetChangeHdl(const class Link<class LinkParamNone *, void> &)
+chart2/source/controller/inc/res_Titles.hxx:73
+    _Bool chart::SchTitleResources::IsModified()
+chart2/source/controller/inc/res_Titles.hxx:74
+    void chart::SchTitleResources::ClearModifyFlag()
 connectivity/source/drivers/evoab2/NResultSetMetaData.hxx:51
     class com::sun::star::uno::Reference<class com::sun::star::sdbc::XResultSetMetaData> connectivity::evoab::OEvoabResultSetMetaData::operator Reference()
 connectivity/source/drivers/firebird/Driver.hxx:65
@@ -46,8 +58,12 @@ connectivity/source/inc/OTypeInfo.hxx:46
     _Bool connectivity::OTypeInfo::operator==(const struct connectivity::OTypeInfo &) const
 connectivity/source/inc/OTypeInfo.hxx:47
     _Bool connectivity::OTypeInfo::operator!=(const struct connectivity::OTypeInfo &) const
-cui/source/inc/cuitabline.hxx:172
-    void SvxLineTabPage::MenuCreate()
+cui/source/options/personasdochandler.hxx:24
+     PersonasDocHandler::PersonasDocHandler()
+cui/source/options/personasdochandler.hxx:25
+    const class std::__debug::vector<class rtl::OUString, class std::allocator<class rtl::OUString> > & PersonasDocHandler::getLearnmoreURLs()
+cui/source/options/personasdochandler.hxx:26
+    _Bool PersonasDocHandler::hasResults()
 dbaccess/source/filter/hsqldb/fbalterparser.hxx:20
     void dbahsql::FbAlterStmtParser::ensureProperTableLengths() const
 dbaccess/source/filter/hsqldb/parseschema.hxx:82
@@ -282,8 +298,6 @@ include/basegfx/utils/b2dclipstate.hxx:75
     _Bool basegfx::utils::B2DClipState::operator!=(const class basegfx::utils::B2DClipState &) const
 include/basegfx/utils/systemdependentdata.hxx:69
      basegfx::MinimalSystemDependentDataManager::MinimalSystemDependentDataManager()
-include/basegfx/utils/systemdependentdata.hxx:116
-    long basegfx::SystemDependentData::estimateUsageInBytes() const
 include/basegfx/utils/unopolypolygon.hxx:91
     const class basegfx::B2DPolyPolygon & basegfx::unotools::UnoPolyPolygon::getPolyPolygonUnsafe() const
 include/basegfx/vector/b2ivector.hxx:75
@@ -380,15 +394,15 @@ include/comphelper/logging.hxx:426
     void comphelper::EventLogger::logp(const int,const char *,const char *,const char *,type-parameter-?-?,type-parameter-?-?,type-parameter-?-?,type-parameter-?-?,type-parameter-?-?,type-parameter-?-?) const
 include/comphelper/lok.hxx:47
     _Bool comphelper::LibreOfficeKit::isLocalRendering()
-include/comphelper/propagg.hxx:55
+include/comphelper/propagg.hxx:59
     _Bool comphelper::internal::OPropertyAccessor::operator==(const struct comphelper::internal::OPropertyAccessor &) const
-include/comphelper/propagg.hxx:56
+include/comphelper/propagg.hxx:60
     _Bool comphelper::internal::OPropertyAccessor::operator<(const struct comphelper::internal::OPropertyAccessor &) const
 include/comphelper/proparrhlp.hxx:87
     class cppu::IPropertyArrayHelper * comphelper::OAggregationArrayUsageHelper::createArrayHelper() const
-include/comphelper/types.hxx:56
+include/comphelper/types.hxx:55
     _Bool comphelper::getImplementation(type-parameter-?-? *&,const class com::sun::star::uno::Reference<class com::sun::star::uno::XInterface> &)
-include/comphelper/unique_disposing_ptr.hxx:46
+include/comphelper/unique_disposing_ptr.hxx:47
     type-parameter-?-? & comphelper::unique_disposing_ptr::operator*() const
 include/comphelper/unwrapargs.hxx:50
     void comphelper::detail::unwrapArgs(const class com::sun::star::uno::Sequence<class com::sun::star::uno::Any> &,int,const class com::sun::star::uno::Reference<class com::sun::star::uno::XInterface> &)
@@ -448,8 +462,6 @@ include/o3tl/enumarray.hxx:132
     const typename type-parameter-?-?::value_type * o3tl::enumarray_const_iterator::operator->() const
 include/o3tl/enumarray.hxx:135
     _Bool o3tl::enumarray_const_iterator::operator==(const enumarray_const_iterator<EA> &) const
-include/o3tl/lru_map.hxx:136
-    void o3tl::lru_map::clear()
 include/o3tl/safeint.hxx:79
     typename enable_if<std::is_unsigned<T>::value, type-parameter-?-?>::type o3tl::saturating_sub(type-parameter-?-?,type-parameter-?-?)
 include/o3tl/string_view.hxx:173
@@ -552,7 +564,9 @@ include/opencl/openclconfig.hxx:55
     _Bool OpenCLConfig::ImplMatcher::operator!=(const struct OpenCLConfig::ImplMatcher &) const
 include/opencl/OpenCLZone.hxx:42
     _Bool OpenCLZone::isInInitialTest()
-include/sfx2/basedlgs.hxx:211
+include/sfx2/basedlgs.hxx:218
+    class SfxTabPage * SfxSingleTabDialogController::GetTabPage() const
+include/sfx2/basedlgs.hxx:219
     class weld::Button & SfxSingleTabDialogController::GetOKButton() const
 include/sfx2/charwin.hxx:63
     void SvxCharView::connect_focus_in(const class Link<class weld::Widget &, void> &)
@@ -566,6 +580,10 @@ include/sfx2/msg.hxx:120
     const class std::type_info * SfxType0::Type() const
 include/sfx2/sidebar/Context.hxx:55
     _Bool sfx2::sidebar::Context::operator==(const class sfx2::sidebar::Context &) const
+include/sfx2/tabdlg.hxx:211
+    const class PushButton * SfxTabDialog::GetUserButton() const
+include/sfx2/tabdlg.hxx:212
+    class PushButton * SfxTabDialog::GetUserButton()
 include/svl/itempool.hxx:167
     const type-parameter-?-? * SfxItemPool::GetItem2Default(TypedWhichId<type-parameter-?-?>) const
 include/svl/itempool.hxx:196
@@ -576,9 +594,9 @@ include/svtools/dialogcontrolling.hxx:167
     void svt::ControlDependencyManager::enableOnCheckMark(class CheckBox &,class vcl::Window &,class vcl::Window &)
 include/svtools/imagemgr.hxx:124
     class rtl::OUString SvFileInformationManager::GetFileImageId(const class INetURLObject &)
-include/svx/ClassificationEditView.hxx:42
+include/svx/ClassificationEditView.hxx:41
     void svx::ClassificationEditView::SetCharAttributes()
-include/svx/ClassificationEditView.hxx:48
+include/svx/ClassificationEditView.hxx:47
     void svx::ClassificationEditView::SetNumType(enum SvxNumType)
 include/svx/ClassificationField.hxx:48
     const class rtl::OUString & svx::ClassificationResult::getDisplayText() const
@@ -594,10 +612,10 @@ include/svx/framelink.hxx:201
     _Bool svx::frame::operator>(const class svx::frame::Style &,const class svx::frame::Style &)
 include/svx/framelink.hxx:238
     _Bool svx::frame::StyleVectorCombination::operator<(const class svx::frame::StyleVectorCombination &) const
-include/svx/svdlayer.hxx:75
+include/svx/numfmtsh.hxx:169
+    short SvxNumberFormatShell::GetListPos4Entry(const class rtl::OUString &)
+include/svx/svdlayer.hxx:76
     _Bool SdrLayer::operator==(const class SdrLayer &) const
-include/svx/svdpagv.hxx:96
-    class std::unique_ptr<class SdrPageWindow, struct std::default_delete<class SdrPageWindow> > SdrPageView::RemovePageWindow(class SdrPageWindow &)
 include/svx/svdpntv.hxx:462
     _Bool SdrPaintView::IsSwapAsynchron() const
 include/svx/xpoly.hxx:82
@@ -702,12 +720,12 @@ include/vcl/inputctx.hxx:63
     _Bool InputContext::operator!=(const class InputContext &) const
 include/vcl/ITiledRenderable.hxx:288
     class Pointer vcl::ITiledRenderable::getPointer()
-include/vcl/lstbox.hxx:259
-    void ListBox::SetEdgeBlending(_Bool)
 include/vcl/opengl/OpenGLHelper.hxx:61
     void OpenGLHelper::renderToFile(long,long,const class rtl::OUString &)
 include/vcl/opengl/OpenGLHelper.hxx:91
     void OpenGLHelper::debugMsgStreamWarn(const class std::__cxx11::basic_ostringstream<char> &)
+include/vcl/salbtype.hxx:125
+    void BitmapColor::SetAlpha(unsigned char)
 include/vcl/salnativewidgets.hxx:387
     _Bool TabitemValue::isBothAligned() const
 include/vcl/salnativewidgets.hxx:388
@@ -736,7 +754,7 @@ include/vcl/svapp.hxx:807
     void Application::AppEvent(const class ApplicationEvent &)
 include/vcl/svmain.hxx:27
     _Bool ImplSVMainHook(int *)
-include/vcl/syswin.hxx:192
+include/vcl/syswin.hxx:173
     void SystemWindow::SetIdleDebugName(const char *)
 include/vcl/textrectinfo.hxx:44
     _Bool TextRectInfo::operator!=(const class TextRectInfo &) const
@@ -754,71 +772,71 @@ include/vcl/uitest/uiobject.hxx:351
     class std::unique_ptr<class UIObject, struct std::default_delete<class UIObject> > SpinUIObject::create(class vcl::Window *)
 include/vcl/wall.hxx:98
     _Bool Wallpaper::operator!=(const class Wallpaper &) const
-include/vcl/weld.hxx:67
-    class rtl::OString weld::Widget::get_buildable_name() const
 include/vcl/weld.hxx:72
-    int weld::Widget::get_grid_left_attach() const
+    class rtl::OString weld::Widget::get_buildable_name() const
 include/vcl/weld.hxx:77
+    int weld::Widget::get_grid_left_attach() const
+include/vcl/weld.hxx:82
     _Bool weld::Widget::get_hexpand() const
-include/vcl/weld.hxx:78
+include/vcl/weld.hxx:83
     void weld::Widget::set_vexpand(_Bool)
-include/vcl/weld.hxx:79
+include/vcl/weld.hxx:84
     _Bool weld::Widget::get_vexpand() const
-include/vcl/weld.hxx:89
+include/vcl/weld.hxx:94
     void weld::Widget::set_tooltip_text(const class rtl::OUString &)
-include/vcl/weld.hxx:141
+include/vcl/weld.hxx:146
     void weld::ScrolledWindow::vadjustment_set_upper(int)
-include/vcl/weld.hxx:142
+include/vcl/weld.hxx:147
     void weld::ScrolledWindow::set_hpolicy(enum VclPolicyType)
-include/vcl/weld.hxx:143
+include/vcl/weld.hxx:148
     enum VclPolicyType weld::ScrolledWindow::get_hpolicy() const
-include/vcl/weld.hxx:172
+include/vcl/weld.hxx:177
     class rtl::OUString weld::Notebook::get_tab_label_text(const class rtl::OString &) const
-include/vcl/weld.hxx:198
+include/vcl/weld.hxx:203
     struct SystemEnvData weld::Window::get_system_data() const
-include/vcl/weld.hxx:341
+include/vcl/weld.hxx:349
     void weld::TreeView::append(const class rtl::OUString &,const class rtl::OUString &,class VirtualDevice &)
-include/vcl/weld.hxx:354
+include/vcl/weld.hxx:362
     void weld::TreeView::set_top_entry(int)
-include/vcl/weld.hxx:385
+include/vcl/weld.hxx:393
     void weld::TreeView::select_all()
-include/vcl/weld.hxx:520
+include/vcl/weld.hxx:529
     void weld::Entry::signal_insert_text(class rtl::OUString &)
-include/vcl/weld.hxx:532
+include/vcl/weld.hxx:541
     int weld::Entry::get_position() const
-include/vcl/weld.hxx:592
+include/vcl/weld.hxx:601
     int weld::SpinButton::get_min() const
-include/vcl/weld.hxx:857
+include/vcl/weld.hxx:866
     class Size weld::MetricSpinButton::get_size_request() const
-include/vcl/weld.hxx:868
+include/vcl/weld.hxx:877
     void weld::MetricSpinButton::set_position(int)
-include/vcl/weld.hxx:915
+include/vcl/weld.hxx:924
     _Bool weld::TimeSpinButton::get_sensitive() const
-include/vcl/weld.hxx:916
+include/vcl/weld.hxx:925
     _Bool weld::TimeSpinButton::get_visible() const
-include/vcl/weld.hxx:917
+include/vcl/weld.hxx:926
     void weld::TimeSpinButton::grab_focus()
-include/vcl/weld.hxx:918
+include/vcl/weld.hxx:927
     _Bool weld::TimeSpinButton::has_focus() const
-include/vcl/weld.hxx:919
+include/vcl/weld.hxx:928
     void weld::TimeSpinButton::show(_Bool)
-include/vcl/weld.hxx:920
+include/vcl/weld.hxx:929
     void weld::TimeSpinButton::hide()
-include/vcl/weld.hxx:921
+include/vcl/weld.hxx:930
     void weld::TimeSpinButton::save_value()
-include/vcl/weld.hxx:922
+include/vcl/weld.hxx:931
     _Bool weld::TimeSpinButton::get_value_changed_from_saved() const
-include/vcl/weld.hxx:1013
+include/vcl/weld.hxx:1022
     void weld::DrawingArea::connect_key_release(const class Link<const class KeyEvent &, _Bool> &)
-include/vcl/weld.hxx:1040
+include/vcl/weld.hxx:1049
     void weld::Menu::set_active(const class rtl::OString &,_Bool)
-include/vcl/weld.hxx:1050
+include/vcl/weld.hxx:1059
     void weld::Menu::append(const class rtl::OUString &,const class rtl::OUString &,const class rtl::OUString &)
-include/vcl/weld.hxx:1066
+include/vcl/weld.hxx:1075
     void weld::SizeGroup::set_mode(enum VclSizeGroupMode)
-include/vcl/weld.hxx:1088
+include/vcl/weld.hxx:1097
     class std::unique_ptr<class weld::Window, struct std::default_delete<class weld::Window> > weld::Builder::weld_window(const class rtl::OString &,_Bool)
-include/vcl/weld.hxx:1199
+include/vcl/weld.hxx:1208
     class rtl::OUString weld::MessageDialogController::get_primary_text() const
 include/vcl/window.hxx:430
     const char * ImplDbgCheckWindow(const void *)
@@ -860,8 +878,8 @@ sc/inc/formulagroup.hxx:142
     void sc::FormulaGroupInterpreter::disableOpenCL_UnitTestsOnly()
 sc/inc/scdll.hxx:36
      ScDLL::ScDLL()
-sc/inc/scmatrix.hxx:622
-    class ScFullMatrix & ScFullMatrix::operator+=(const class ScFullMatrix &)
+sc/inc/scmatrix.hxx:415
+    class ScMatrix & ScMatrix::operator+=(const class ScMatrix &)
 sc/inc/stlalgorithm.hxx:61
     _Bool sc::AlignedAllocator::operator==(const AlignedAllocator<T, Alignment> &) const
 sc/inc/stlalgorithm.hxx:62
@@ -908,7 +926,7 @@ sc/source/core/opencl/op_statistical.hxx:204
      sc::opencl::OpGeoMean::OpGeoMean()
 sc/source/core/tool/scmatrix.cxx:2354
     type-parameter-?-? * wrapped_iterator::operator->() const
-sc/source/core/tool/scmatrix.cxx:3370
+sc/source/core/tool/scmatrix.cxx:3364
     const class svl::SharedString & matop::COp::operator()(char,type-parameter-?-?,double,double,const class svl::SharedString &) const
 sc/source/filter/inc/htmlpars.hxx:60
     void ScHTMLStyles::add(const char *,unsigned long,const char *,unsigned long,const class rtl::OUString &,const class rtl::OUString &)
@@ -940,6 +958,8 @@ sc/source/ui/inc/RandomNumberGeneratorDialog.hxx:69
     void ScRandomNumberGeneratorDialog::GenerateNumbers(type-parameter-?-? &,const char *,const class boost::optional<signed char>)
 sc/source/ui/inc/TableFillingAndNavigationTools.hxx:125
     unsigned long DataRangeIterator::size()
+sc/source/ui/inc/validate.hxx:268
+    void ScTPValidationHelp::Init()
 sc/source/ui/inc/viewdata.hxx:406
     long ScViewData::GetLOKDocWidthPixel() const
 sc/source/ui/inc/viewdata.hxx:407
@@ -1190,15 +1210,15 @@ ucb/source/ucp/webdav-neon/NeonUri.hxx:64
     _Bool webdav_ucp::NeonUri::operator!=(const class webdav_ucp::NeonUri &) const
 vcl/inc/bitmapwriteaccess.hxx:75
     void BitmapWriteAccess::SetFillColor()
-vcl/inc/fontinstance.hxx:62
+vcl/inc/fontinstance.hxx:65
     void LogicalFontInstance::SetAverageWidthFactor(double)
-vcl/inc/fontinstance.hxx:64
+vcl/inc/fontinstance.hxx:67
     double LogicalFontInstance::GetAverageWidthFactor() const
-vcl/inc/fontinstance.hxx:81
+vcl/inc/fontinstance.hxx:87
     void LogicalFontInstance::ReleaseHbFont()
 vcl/inc/fontselect.hxx:49
     _Bool FontSelectPattern::operator!=(const class FontSelectPattern &) const
-vcl/inc/headless/svpgdi.hxx:245
+vcl/inc/headless/svpgdi.hxx:247
     void SvpSalGraphics::drawBitmap(const struct SalTwoRect &,struct BitmapBuffer *,enum _cairo_operator)
 vcl/inc/impgraph.hxx:57
     _Bool GraphicID::operator==(const class GraphicID &) const
@@ -1252,7 +1272,7 @@ vcl/inc/salwtype.hxx:115
      SalMenuEvent::SalMenuEvent()
 vcl/inc/schedulerimpl.hxx:37
     const char * ImplSchedulerData::GetDebugName() const
-vcl/inc/unx/glyphcache.hxx:72
+vcl/inc/unx/glyphcache.hxx:70
     void GlyphCache::ClearFontOptions()
 vcl/inc/unx/gtk/gtkdata.hxx:191
     void GtkSalDisplay::RefreshMenusUnity()
@@ -1264,6 +1284,8 @@ vcl/inc/unx/saldisp.hxx:386
     class SalXLib * SalDisplay::GetXLib() const
 vcl/inc/unx/salframe.h:187
     enum SalFrameStyleFlags X11SalFrame::GetStyle() const
+vcl/inc/unx/salgdi.h:308
+    void X11SalGraphics::releaseGlyphPeer()
 vcl/source/app/scheduler.cxx:81
     basic_ostream<type-parameter-?-?, type-parameter-?-?> & (anonymous namespace)::operator<<(basic_ostream<type-parameter-?-?, type-parameter-?-?> &,const class Idle &)
 vcl/source/edit/textdat2.hxx:85
@@ -1282,10 +1304,10 @@ vcl/source/fontsubset/xlat.hxx:34
     unsigned short vcl::TranslateChar15(unsigned short)
 vcl/source/fontsubset/xlat.hxx:35
     unsigned short vcl::TranslateChar16(unsigned short)
+workdir/LexTarget/l10ntools/source/cfglex.cxx:3721
+    void YYWarning(const char *)
 workdir/LexTarget/l10ntools/source/xrmlex.cxx:715
     void YYWarning()
-workdir/LexTarget/l10ntools/source/xrmlex.cxx:2211
-    void YYWarning(const char *)
 writerfilter/source/ooxml/OOXMLPropertySet.hxx:176
     class __gnu_debug::_Safe_iterator<class __gnu_cxx::__normal_iterator<const class tools::SvRef<class writerfilter::ooxml::OOXMLProperty> *, class std::__cxx1998::vector<class tools::SvRef<class writerfilter::ooxml::OOXMLProperty>, class std::allocator<class tools::SvRef<class writerfilter::ooxml::OOXMLProperty> > > >, class std::__debug::vector<class tools::SvRef<class writerfilter::ooxml::OOXMLProperty>, class std::allocator<class tools::SvRef<class writerfilter::ooxml::OOXMLProperty> > > > writerfilter::ooxml::OOXMLPropertySet::begin() const
 writerfilter/source/ooxml/OOXMLPropertySet.hxx:177
diff --git a/compilerplugins/clang/unusedmethods.unused-returns.results b/compilerplugins/clang/unusedmethods.unused-returns.results
index 317f6a014776..48b8e80c3ba0 100644
--- a/compilerplugins/clang/unusedmethods.unused-returns.results
+++ b/compilerplugins/clang/unusedmethods.unused-returns.results
@@ -144,8 +144,6 @@ include/sfx2/linkmgr.hxx:64
     _Bool sfx2::LinkManager::InsertLink(class sfx2::SvBaseLink *,unsigned short,enum SfxLinkUpdateMode,const class rtl::OUString *)
 include/sfx2/lnkbase.hxx:103
     class sfx2::SvLinkSource * sfx2::SvBaseLink::GetRealObject()
-include/svl/listener.hxx:55
-    _Bool SvtListener::EndListening(class SvtBroadcaster &)
 include/svl/macitem.hxx:92
     class SvStream & SvxMacroTableDtor::Write(class SvStream &) const
 include/svl/poolitem.hxx:173
@@ -198,9 +196,9 @@ include/vcl/texteng.hxx:279
     _Bool TextEngine::Read(class SvStream &,const class TextSelection *)
 include/vcl/toolbox.hxx:514
     _Bool ToolBox::ChangeHighlightUpDn(_Bool)
-include/vcl/weld.hxx:308
+include/vcl/weld.hxx:316
     _Bool weld::ComboBox::get_entry_selection_bounds(int &,int &)
-include/vcl/weld.hxx:947
+include/vcl/weld.hxx:956
     _Bool weld::TextView::get_selection_bounds(int &,int &)
 lotuswordpro/inc/lwpsvstream.hxx:76
     class LwpSvStream & LwpSvStream::ReadUInt8(unsigned char &)
@@ -274,7 +272,7 @@ sw/inc/editsh.hxx:264
     _Bool SwEditShell::GetPaMParAttr(class SwPaM *,class SfxItemSet &) const
 sw/inc/editsh.hxx:635
     const class GraphicAttr * SwEditShell::GetGraphicAttr(class GraphicAttr &) const
-sw/inc/IDocumentUndoRedo.hxx:180
+sw/inc/IDocumentUndoRedo.hxx:181
     _Bool IDocumentUndoRedo::Repeat(class sw::RepeatContext &,const unsigned short)
 sw/inc/swcrsr.hxx:156
     _Bool SwCursor::ExpandToSentenceBorders(const class SwRootFrame *)
diff --git a/cui/Library_cui.mk b/cui/Library_cui.mk
index a959742a906c..4db46539816c 100644
--- a/cui/Library_cui.mk
+++ b/cui/Library_cui.mk
@@ -177,7 +177,6 @@ $(eval $(call gb_Library_add_exception_objects,cui,\
     cui/source/options/optupdt \
     $(call gb_Helper_optional,DESKTOP,\
         cui/source/options/personalization) \
-    cui/source/options/personasdochandler \
     cui/source/options/radiobtnbox \
     cui/source/options/sdbcdriverenum \
     cui/source/options/securityoptions \
diff --git a/cui/source/options/personalization.cxx b/cui/source/options/personalization.cxx
index 97da2d1878d1..0c88f9adf325 100644
--- a/cui/source/options/personalization.cxx
+++ b/cui/source/options/personalization.cxx
@@ -10,7 +10,6 @@
 #include <config_folders.h>
 
 #include "personalization.hxx"
-#include "personasdochandler.hxx"
 
 #include <comphelper/processfactory.hxx>
 #include <officecfg/Office/Common.hxx>
diff --git a/cui/source/options/personasdochandler.cxx b/cui/source/options/personasdochandler.cxx
deleted file mode 100644
index 90809abaa99d..000000000000
--- a/cui/source/options/personasdochandler.cxx
+++ /dev/null
@@ -1,71 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- */
-
-#include "personasdochandler.hxx"
-
-using namespace ::com::sun::star;
-using namespace ::com::sun::star::uno;
-
-// XDocumentHandler
-void SAL_CALL
-PersonasDocHandler::startDocument()
-{
-}
-
-void SAL_CALL
-PersonasDocHandler::endDocument()
-{
-}
-
-void SAL_CALL
-PersonasDocHandler::characters( const OUString & aChars)
-{
-    if( m_isLearnmoreTag )
-        m_vLearnmoreURLs.push_back( aChars );
-}
-
-void SAL_CALL
-PersonasDocHandler::ignorableWhitespace( const OUString & )
-{
-}
-
-void SAL_CALL
-PersonasDocHandler::processingInstruction(
-    const OUString &, const OUString & )
-{
-}
-
-void SAL_CALL
-PersonasDocHandler::setDocumentLocator(
-    const Reference< xml::sax::XLocator >& )
-{
-}
-
-void SAL_CALL
-PersonasDocHandler::startElement( const OUString& aName,
-    const Reference< xml::sax::XAttributeList > &xAttribs )
-{
-    if( aName == "searchresults" )
-    {
-        OUString aTotalResults = xAttribs->getValueByName( "total_results" );
-        if( aTotalResults != "0" )
-            m_hasResults = true;
-    }
-
-    if ( aName == "learnmore" )
-        m_isLearnmoreTag = true;
-    else
-        m_isLearnmoreTag = false;
-}
-
-void SAL_CALL PersonasDocHandler::endElement( const OUString & )
-{
-}
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/cui/source/options/personasdochandler.hxx b/cui/source/options/personasdochandler.hxx
deleted file mode 100644
index 3e3f58ef5d92..000000000000
--- a/cui/source/options/personasdochandler.hxx
+++ /dev/null
@@ -1,51 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- */
-
-#ifndef INCLUDED_CUI_SOURCE_OPTIONS_PERSONASDOCHANDLER_HXX
-#define INCLUDED_CUI_SOURCE_OPTIONS_PERSONASDOCHANDLER_HXX
-
-#include <cppuhelper/implbase.hxx>
-#include <com/sun/star/xml/sax/XAttributeList.hpp>
-#include <com/sun/star/xml/sax/XParser.hpp>
-#include <vector>
-
-class PersonasDocHandler : public ::cppu::WeakImplHelper< css::xml::sax::XDocumentHandler >
-{
-private:
-    std::vector<OUString> m_vLearnmoreURLs;
-    bool m_isLearnmoreTag, m_hasResults;
-public:
-    PersonasDocHandler(){ m_isLearnmoreTag = false; m_hasResults = false; }
-    const std::vector<OUString>& getLearnmoreURLs() { return m_vLearnmoreURLs; }
-    bool hasResults() { return m_hasResults; }
-
-    // XDocumentHandler
-    virtual void SAL_CALL startDocument() override;
-
-    virtual void SAL_CALL endDocument() override;
-
-    virtual void SAL_CALL startElement( const OUString& aName,
-        const css::uno::Reference< css::xml::sax::XAttributeList > & xAttribs ) override;
-
-    virtual void SAL_CALL endElement( const OUString & aName ) override;
-
-    virtual void SAL_CALL characters( const OUString & aChars ) override;
-
-    virtual void SAL_CALL ignorableWhitespace( const OUString & aWhitespaces ) override;
-
-    virtual void SAL_CALL processingInstruction(
-        const OUString & aTarget, const OUString & aData ) override;
-
-    virtual void SAL_CALL setDocumentLocator(
-        const css::uno::Reference< css::xml::sax::XLocator >& xLocator ) override;
-};
-
-#endif // INCLUDED_CUI_SOURCE_OPTIONS_PERSONASDOCHANDLER_HXX
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/sfx2/basedlgs.hxx b/include/sfx2/basedlgs.hxx
index bb861366f9d7..d2ba78be8c37 100644
--- a/include/sfx2/basedlgs.hxx
+++ b/include/sfx2/basedlgs.hxx
@@ -215,7 +215,6 @@ public:
     virtual             ~SfxSingleTabDialogController() override;
 
     void                SetTabPage(SfxTabPage* pTabPage);
-    SfxTabPage*         GetTabPage() const { return m_xSfxPage; }
     weld::Button&       GetOKButton() const { return *m_xOKBtn; }
 
     const SfxItemSet*   GetOutputItemSet() const { return m_xOutputSet.get(); }
diff --git a/include/sfx2/tabdlg.hxx b/include/sfx2/tabdlg.hxx
index 4f18f9b91497..3c5b26ef7144 100644
--- a/include/sfx2/tabdlg.hxx
+++ b/include/sfx2/tabdlg.hxx
@@ -208,8 +208,6 @@ public:
     const CancelButton& GetCancelButton() const { return *m_pCancelBtn; }
     CancelButton&       GetCancelButton() { return *m_pCancelBtn; }
 
-    const PushButton*   GetUserButton() const { return m_pUserBtn; }
-    PushButton*         GetUserButton() { return m_pUserBtn; }
     void                RemoveResetButton();
     void                RemoveStandardButton();
 
diff --git a/include/svx/numfmtsh.hxx b/include/svx/numfmtsh.hxx
index 81b409b1065a..8f1b0262f1cd 100644
--- a/include/svx/numfmtsh.hxx
+++ b/include/svx/numfmtsh.hxx
@@ -166,7 +166,6 @@ public:
     sal_uInt16          FindCurrencyFormat(const NfCurrencyEntry* pTmpCurrencyEntry,bool bTmpBanking);
     void                SetCurCurrencyEntry(NfCurrencyEntry*);
     short               GetListPos4Entry(sal_uInt32 nIdx);
-    short               GetListPos4Entry( const OUString& rFmtString );
 
     void                GetCurrencySymbols(std::vector<OUString>& rList, sal_uInt16* pPos );
 
diff --git a/sc/inc/scmatrix.hxx b/sc/inc/scmatrix.hxx
index 12baa8e1e7ed..7b08d5e0eb6d 100644
--- a/sc/inc/scmatrix.hxx
+++ b/sc/inc/scmatrix.hxx
@@ -412,8 +412,6 @@ public:
     void MatConcat(SCSIZE nMaxCol, SCSIZE nMaxRow, const ScMatrixRef& xMat1, const ScMatrixRef& xMat2,
             SvNumberFormatter& rFormatter, svl::SharedStringPool& rPool) ;
 
-    ScMatrix& operator+= ( const ScMatrix& r );
-
 #if DEBUG_MATRIX
     void Dump() const;
 #endif
diff --git a/sc/source/core/tool/scmatrix.cxx b/sc/source/core/tool/scmatrix.cxx
index 4442c815a0fe..c029cac75ace 100644
--- a/sc/source/core/tool/scmatrix.cxx
+++ b/sc/source/core/tool/scmatrix.cxx
@@ -319,7 +319,6 @@ public:
 
     void GetDoubleArray( std::vector<double>& rArray, bool bEmptyAsZero ) const;
     void MergeDoubleArray( std::vector<double>& rArray, ScMatrix::Op eOp ) const;
-    void AddValues( const ScMatrixImpl& rMat );
 
     template<typename T>
     void ApplyOperation(T aOp, ScMatrixImpl& rMat);
@@ -2201,61 +2200,6 @@ void ScMatrixImpl::MergeDoubleArray( std::vector<double>& rArray, ScMatrix::Op e
     }
 }
 
-void ScMatrixImpl::AddValues( const ScMatrixImpl& rMat )
-{
-    const MatrixImplType& rOther = rMat.maMat;
-    MatrixImplType::size_pair_type aSize = maMat.size();
-    if (aSize != rOther.size())
-        // Geometry must match.
-        return;
-
-    // For now, we only add two matricies if and only if 1) the receiving
-    // matrix consists only of one numeric block, and 2) the other matrix
-    // consists of either one numeric block or one boolean block.  In the
-    // future, we may want to be more flexible support matricies that consist
-    // of multiple blocks.
-
-    MatrixImplType::position_type aPos1 = maMat.position(0, 0);
-    MatrixImplType::const_position_type aPos2 = rOther.position(0, 0);
-    if (MatrixImplType::to_mtm_type(aPos1.first->type) != mdds::mtm::element_numeric)
-        return;
-
-    if (aPos1.first->size != aPos2.first->size)
-        return;
-
-    if (aPos1.first->size != aSize.row * aSize.column)
-        return;
-
-    MatrixImplType::numeric_block_type::iterator it =
-        MatrixImplType::numeric_block_type::begin(*aPos1.first->data);
-    MatrixImplType::numeric_block_type::iterator itEnd =
-        MatrixImplType::numeric_block_type::end(*aPos1.first->data);
-
-    switch (MatrixImplType::to_mtm_type(aPos2.first->type))
-    {
-        case mdds::mtm::element_boolean:
-        {
-            MatrixImplType::boolean_block_type::iterator it2 =
-                MatrixImplType::boolean_block_type::begin(*aPos2.first->data);
-
-            for (; it != itEnd; ++it, ++it2)
-                *it += *it2;
-        }
-        break;
-        case mdds::mtm::element_numeric:
-        {
-            MatrixImplType::numeric_block_type::iterator it2 =
-                MatrixImplType::numeric_block_type::begin(*aPos2.first->data);
-
-            for (; it != itEnd; ++it, ++it2)
-                *it += *it2;
-        }
-        break;
-        default:
-            ;
-    }
-}
-
 namespace Op {
 
 template<typename T>
@@ -3529,12 +3473,6 @@ std::vector<ScMatrix::IterateResult> ScMatrix::Collect(const std::vector<std::un
     return pImpl->ApplyCollectOperation(aOp);
 }
 
-ScMatrix& ScMatrix::operator+= ( const ScMatrix& r )
-{
-    pImpl->AddValues(*r.pImpl);
-    return *this;
-}
-
 #if DEBUG_MATRIX
 void ScMatrix::Dump() const
 {
diff --git a/sc/source/ui/inc/validate.hxx b/sc/source/ui/inc/validate.hxx
index bb9d262ee968..1faf86bbd510 100644
--- a/sc/source/ui/inc/validate.hxx
+++ b/sc/source/ui/inc/validate.hxx
@@ -265,8 +265,6 @@ private:
     std::unique_ptr<weld::Entry> m_xEdtTitle;
     std::unique_ptr<weld::TextView> m_xEdInputHelp;
 
-    void    Init();
-
 public:
     ScTPValidationHelp(TabPageParent pParent, const SfxItemSet& rArgSet);
     virtual ~ScTPValidationHelp() override;
diff --git a/svx/source/items/numfmtsh.cxx b/svx/source/items/numfmtsh.cxx
index bcfe11c2fa35..b8c6ac4be8a9 100644
--- a/svx/source/items/numfmtsh.cxx
+++ b/svx/source/items/numfmtsh.cxx
@@ -1354,31 +1354,6 @@ short SvxNumberFormatShell::GetListPos4Entry(sal_uInt32 nIdx)
     return nSelP;
 }
 
-short SvxNumberFormatShell::GetListPos4Entry(const OUString& rFmtString)
-{
-    sal_uInt32 nAt = 0;
-    short nSelP = SELPOS_NONE;
-    if (FindEntry(rFmtString, &nAt))
-    {
-        if (NUMBERFORMAT_ENTRY_NOT_FOUND != nAt && NUMBERFORMAT_ENTRY_NEW_CURRENCY != nAt)
-        {
-            nSelP = GetListPos4Entry(nAt);
-        }
-        else
-        {
-            for (size_t i = 0; i < aCurrencyFormatList.size(); i++)
-            {
-                if (rFmtString == aCurrencyFormatList[i])
-                {
-                    nSelP = static_cast<short>(i);
-                    break;
-                }
-            }
-        }
-    }
-    return nSelP;
-}
-
 OUString SvxNumberFormatShell::GetStandardName() const
 {
     return pFormatter->GetStandardName(eCurLanguage);